-
Notifications
You must be signed in to change notification settings - Fork 69
CCS version support information #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the CCS version support information by updating the compatibility table to reflect accurate support indicators.
- Corrected the support indicator for version 8.18 in the compatibility table.
Comments suppressed due to low confidence (1)
solutions/search/cross-cluster-search.md:1120
- Verify that the change to the 'No' indicator for the local cluster version in the 8.18 row is intentional and aligns with the documented compatibility specifications. If local cluster support exists for 8.18, update the icon accordingly.
| 8.18 |  |  |  |  |
@@ -1117,7 +1117,7 @@ $$$ccs-version-compatibility$$$ | |||
| Local cluster version | 7.17 | 8.0 – 8.17 | 8.18 | 9.0 | | |||
| 7.17 |  |  |  |  | | |||
| 8.0 – 8.17 |  |  |  |  | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this 8.0-8.17 "Yes" is also wrong. We only support back to 7.17 from 8.0, but not 8.1, following the "previous minor" rule. This is shown correctly on this page: https://www.elastic.co/guide/en/elasticsearch/reference/8.18/modules-cross-cluster-search.html#ccs-supported-configurations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
You’re right that based on the “previous minor” rule, only 8.0 from the 8.0–8.17 range supports querying 7.17. The table here (compared to the other one) uses a simplified format, where support is marked if any version in the range supports a pairing.
That said, I see how this could be misleading. I’m happy to adjust the structure—for example, breaking out 8.0 into its own row.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this has already merged, but isn't the intersection of 8.1-8.17
and 8.0-8.16
still incorrect? It indicates a local 8.17
can CCS against a remote 8.0
.
Don't we need to list every minor version in the headers as we did in 8.x
docs for complete accuracy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rseldner shouldn't this page be analogous to the 8.0 version?
Michael pointed out this still wasn't accurate :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for making this change!
This PR is fixing CCS version support information.
Based on #1350