Skip to content

CCS version support information #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

CCS version support information #1359

merged 2 commits into from
May 5, 2025

Conversation

charlotte-hoblik
Copy link
Contributor

This PR is fixing CCS version support information.
Based on #1350

@charlotte-hoblik charlotte-hoblik added the documentation Improvements or additions to documentation label May 5, 2025
@charlotte-hoblik charlotte-hoblik requested a review from Copilot May 5, 2025 09:46
@charlotte-hoblik charlotte-hoblik self-assigned this May 5, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the CCS version support information by updating the compatibility table to reflect accurate support indicators.

  • Corrected the support indicator for version 8.18 in the compatibility table.
Comments suppressed due to low confidence (1)

solutions/search/cross-cluster-search.md:1120

  • Verify that the change to the 'No' indicator for the local cluster version in the 8.18 row is intentional and aligns with the documented compatibility specifications. If local cluster support exists for 8.18, update the icon accordingly.
| 8.18 | ![No](https://doc-icons.s3.us-east-2.amazonaws.com/icon-no.png "") | ![Yes](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png "") | ![Yes](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png "") |  ![Yes](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png "") |

@leemthompo leemthompo requested a review from quux00 May 5, 2025 10:32
leemthompo

This comment was marked as outdated.

@charlotte-hoblik
Copy link
Contributor Author

The CCS support matrix after correction: Screenshot 2025-05-05 at 12 34 43

@@ -1117,7 +1117,7 @@ $$$ccs-version-compatibility$$$
| Local cluster version | 7.17 | 8.0 – 8.17 | 8.18 | 9.0 |
| 7.17 | ![Yes](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png "") | ![Yes](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png "") | ![Yes](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png "") | ![No](https://doc-icons.s3.us-east-2.amazonaws.com/icon-no.png "") |
| 8.0 – 8.17 | ![Yes](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png "") | ![Yes](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png "") | ![Yes](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png "") | ![No](https://doc-icons.s3.us-east-2.amazonaws.com/icon-no.png "") |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this 8.0-8.17 "Yes" is also wrong. We only support back to 7.17 from 8.0, but not 8.1, following the "previous minor" rule. This is shown correctly on this page: https://www.elastic.co/guide/en/elasticsearch/reference/8.18/modules-cross-cluster-search.html#ccs-supported-configurations

Copy link
Contributor Author

@charlotte-hoblik charlotte-hoblik May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

You’re right that based on the “previous minor” rule, only 8.0 from the 8.0–8.17 range supports querying 7.17. The table here (compared to the other one) uses a simplified format, where support is marked if any version in the range supports a pairing.

That said, I see how this could be misleading. I’m happy to adjust the structure—for example, breaking out 8.0 into its own row.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve made the changes we discussed:
• 8.0 now has its own row
• 8.17 is split into a separate column for clarity

Here’s the updated version. Let me know what you think! Screenshot 2025-05-05 at 16 44 28

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this has already merged, but isn't the intersection of 8.1-8.17 and 8.0-8.16 still incorrect? It indicates a local 8.17 can CCS against a remote 8.0.

Don't we need to list every minor version in the headers as we did in 8.x docs for complete accuracy?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leemthompo leemthompo dismissed their stale review May 5, 2025 13:00

Michael pointed out this still wasn't accurate :)

@charlotte-hoblik charlotte-hoblik requested a review from quux00 May 5, 2025 14:53
Copy link

@quux00 quux00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making this change!

@charlotte-hoblik charlotte-hoblik merged commit b6efca9 into main May 5, 2025
4 checks passed
@charlotte-hoblik charlotte-hoblik deleted the charlotte-ccs-fix branch May 5, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants