Skip to content

Update tail-based-sampling.md #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update tail-based-sampling.md #1360

wants to merge 1 commit into from

Conversation

endorama
Copy link
Member

@endorama endorama commented May 5, 2025

A minor change to the data type for sample_rate. We mention that

The sample rate must be greater than or equal to 0 and less than or equal to 1.

which if restricted to an int type would only allow 0 and 1. A more reasonable (unless there is a reason not clear to me) data type here would be float, allowing any decimal precision value, like the 0.01 mentioned as example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant