Skip to content

Fix dynamic_templates type #3909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Fix dynamic_templates type #3909

merged 1 commit into from
Mar 7, 2025

Conversation

flobernd
Copy link
Member

@flobernd flobernd commented Mar 7, 2025

As titled. Thanks for checking the server code @l-trotta .

@flobernd flobernd requested a review from a team March 7, 2025 09:42
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Following you can find the validation results for the API you have changed.

API Status Request Response
indices.put_mapping 🟢 114/114 117/117

You can validate this API yourself by using the make validate target.

Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! not backporting to 8.17 since it's a breaking change for java

@flobernd flobernd merged commit d2b8209 into main Mar 7, 2025
17 of 21 checks passed
@flobernd flobernd deleted the fix-dynamic-templates-2 branch March 7, 2025 10:41
github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
(cherry picked from commit d2b8209)
github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
(cherry picked from commit d2b8209)
github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
(cherry picked from commit d2b8209)
flobernd added a commit that referenced this pull request Mar 7, 2025
(cherry picked from commit d2b8209)

Co-authored-by: Florian Bernd <[email protected]>
flobernd added a commit that referenced this pull request Mar 7, 2025
(cherry picked from commit d2b8209)

Co-authored-by: Florian Bernd <[email protected]>
flobernd added a commit that referenced this pull request Mar 7, 2025
(cherry picked from commit d2b8209)

Co-authored-by: Florian Bernd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants