Fix requestBodyRequired #5465
Merged
Fix requestBodyRequired #5465
+303
−185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
pquentin
commented
Oct 10, 2025
|
|
||
| // validate body | ||
| if (bodyMember != null) { | ||
| mapping.requestBodyRequired = !(bodyMember as PropertySignature).hasQuestionToken() |
There was a problem hiding this comment.
We check if the body has a question token, that is, if it is written as body?: ....
This was already applied in the case of bodyValue below (line 319/320), but this branch was missed, which means the default from rest-api-spec, "required: false," was taking over.
l-trotta
approved these changes
Oct 10, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5465-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 62d200f5597fbf3529686f7ae7063d6b0a77f1cb
# Push it to GitHub
git push --set-upstream origin backport-5465-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
(cherry picked from commit 62d200f)
pquentin
added a commit
that referenced
this pull request
Oct 10, 2025
(cherry picked from commit 62d200f) # Conflicts: # output/openapi/elasticsearch-openapi.json # output/openapi/elasticsearch-serverless-openapi.json # output/schema/schema.json
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
pquentin
added a commit
that referenced
this pull request
Oct 10, 2025
pquentin
added a commit
that referenced
this pull request
Oct 10, 2025
(cherry picked from commit 62d200f) Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was incorrectly set to false for 68 APIs.