-
Notifications
You must be signed in to change notification settings - Fork 25.2k
ESQL: some more test for FROM #111540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Related: #104987 |
I'm going to have a crack at this. I'm keen to help out with the code base :) |
@alex-spies is it actually correct/expected that a wild card pattern for a nonexistent index prefix won't throw an error? Using your examples, if only Is this behaviour explicitly documented anywhere? All I could find was this doc page, which doesn't describe behaviour for querying missing indices. |
Thanks a lot @calamont !
This is indeed intended. The rationale being that if you ask for a specific index, you probably really wanted it, but for an index pattern, it's okay if it doesn't match anything. This behavior is (mostly) consistent with I agree that we should document this. Since we'll be making changes to the docs anyway (to link actual examples from the csv tests), I think we can also add a note to the doc page you linked. |
Hi @calamont, are you still working on this? Else I would really love to take over or collaborate with you |
I foolishly picked this up the week before I started a new job and moved apartment 😞 Things are getting quiet(er) now but I probably won't get back to this for another few weeks. So if you want to take it, go ahead @jonny5203 :) |
FROM
query still correct? E.g. if there's an indexindex1
but noindex2
, thenFROM index*
is correct,FROM index1
as well,FROM index1, index2*
probably as well, butFROM index1, index2
as well asFROM index2*
probably are not.The text was updated successfully, but these errors were encountered: