Skip to content

[CI] RepositoriesFileSettingsIT testSettingsApplied failing #116694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elasticsearchmachine opened this issue Nov 12, 2024 · 5 comments · Fixed by #126720
Closed

[CI] RepositoriesFileSettingsIT testSettingsApplied failing #116694

elasticsearchmachine opened this issue Nov 12, 2024 · 5 comments · Fixed by #126720
Assignees
@prdoyle
Labels
:Core/Infra/Core Core issues without another label low-risk An open issue or test failure that is a low risk to future releases Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 12, 2024 •
edited
Loading

Build Scans:

Reproduction Line:

./gradlew ":server:internalClusterTest" --tests "org.elasticsearch.reservedstate.service.RepositoriesFileSettingsIT.testSettingsApplied" -Dtests.seed=275ACE586394263D -Dtests.locale=ff-Adlm-GN -Dtests.timezone=Universal -Druntime.java=23

Applicable branches:
8.16

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.util.concurrent.ExecutionException: org.elasticsearch.repositories.RepositoryMissingException: [repo, repo1] missing

Issue Reasons:

  • [8.16] 8 failures in test testSettingsApplied (1.5% fail rate in 532 executions)
  • [8.16] 3 failures in step ubuntu-2004-aarch64_checkpart1_platform-support-arm (17.6% fail rate in 17 executions)
  • [8.16] 7 failures in pipeline elasticsearch-periodic-platform-support (33.3% fail rate in 21 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Core/Infra/Core Core issues without another label >test-failure Triaged test failures from CI labels Nov 12, 2024
elasticsearchmachine added a commit that referenced this issue Nov 12, 2024
@elasticsearchmachine
Mute org.elasticsearch.reservedstate.service.RepositoriesFileSettings…
1bc5e33 
…IT testSettingsApplied #116694
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 2 failures in test testSettingsApplied (0.9% fail rate in 214 executions)

Build Scans:

@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team needs:risk Requires assignment of a risk label (low, medium, blocker) labels Nov 12, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-core-infra (Team:Core/Infra)

jozala pushed a commit that referenced this issue Nov 13, 2024
@elasticsearchmachine @jozala
Mute org.elasticsearch.reservedstate.service.RepositoriesFileSettings…
0475d0c 
…IT testSettingsApplied #116694
afoucret pushed a commit to afoucret/elasticsearch that referenced this issue Nov 14, 2024
@elasticsearchmachine @afoucret
Mute org.elasticsearch.reservedstate.service.RepositoriesFileSettings…
a7e193c 
…IT testSettingsApplied elastic#116694
@prdoyle
Copy link
Contributor

prdoyle commented Nov 14, 2024

Rerunning here.

@n1v0lg
Copy link
Contributor

n1v0lg commented Nov 25, 2024 •
edited
Loading

@prdoyle I think this is failing because unlike other such tests, we don't wait for the correct version in assertClusterStateSaveOK. For similar tests, e.g., here:

elasticsearch/x-pack/plugin/slm/src/internalClusterTest/java/org/elasticsearch/xpack/slm/SLMFileSettingsIT.java

Lines 197 to 199 in 66dd432

final ClusterStateResponse clusterStateResponse = clusterAdmin().state(
new ClusterStateRequest(TEST_REQUEST_TIMEOUT).waitForMetadataVersion(metadataVersion.get())
).get();
we have a get cluster state call with a waitForMetadataVersion param. I think we want the same for the failing repository test to ensure that by the time we are asserting on results, the relevant state update was applied.

alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this issue Nov 28, 2024
@elasticsearchmachine @alexey-ivanov-es
Mute org.elasticsearch.reservedstate.service.RepositoriesFileSettings…
a9a4083 
…IT testSettingsApplied elastic#116694
@ldematte ldematte added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Dec 6, 2024
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch 8.x

Mute Reasons:

  • [8.x] 5 failures in test testSettingsApplied (0.7% fail rate in 761 executions)
  • [8.x] 2 failures in step windows-2019_checkpart1_platform-support-windows (13.3% fail rate in 15 executions)
  • [8.x] 4 failures in pipeline elasticsearch-periodic-platform-support (19.0% fail rate in 21 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Dec 10, 2024
@elasticsearchmachine
Mute org.elasticsearch.reservedstate.service.RepositoriesFileSettings…
570cdcc 
…IT testSettingsApplied #116694
@mosche mosche assigned prdoyle and unassigned JVerwolf Jan 21, 2025
@prdoyle prdoyle mentioned this issue Apr 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prdoyle prdoyle

Labels
:Core/Infra/Core Core issues without another label low-risk An open issue or test failure that is a low risk to future releases Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RepositoriesFileSettingsIT to wait for metadataVersion prdoyle/elasticsearch
5 participants
@prdoyle @ldematte @n1v0lg @JVerwolf @elasticsearchmachine