Skip to content

[CI] SearchableSnapshotsIntegTests testCreateAndRestoreSearchableSnapshot failing #119709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elasticsearchmachine opened this issue Jan 7, 2025 · 13 comments
Labels
:Distributed Indexing/Searchable Snapshots Searchable snapshots / frozen indices. medium-risk An open issue or test failure that is a medium risk to future releases Team:Distributed Indexing Meta label for Distributed Indexing team >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 7, 2025

Build Scans:

Reproduction Line:

./gradlew ":x-pack:plugin:searchable-snapshots:internalClusterTest" --tests "org.elasticsearch.xpack.searchablesnapshots.SearchableSnapshotsIntegTests.testCreateAndRestoreSearchableSnapshot" -Dtests.seed=CA65EAE19FFC2A5C -Dtests.locale=fur-IT -Dtests.timezone=SystemV/CST6CDT -Druntime.java=24

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: Index{id='tlSFDTRjRM/C0kqyDz8R0iy18ccAYF4Rw/6IdUt1iTR2mem7xfzwzZRA/5/_c_Lucene101_1.doc/@0', seqNo=841, primaryTerm=1, version=1, autoGeneratedIdTimestamp=-1}
Expected: <2L>
     but: was <1L>

Issue Reasons:

  • [main] 2 failures in test testCreateAndRestoreSearchableSnapshot (0.7% fail rate in 273 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.

@elasticsearchmachine elasticsearchmachine added :Search Foundations/Search Catch all for Search Foundations >test-failure Triaged test failures from CI needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels Jan 7, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@piergm piergm self-assigned this Jan 17, 2025
@piergm piergm added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Jan 24, 2025
@piergm
Copy link
Member

piergm commented Jan 24, 2025

The test did not get muted and did not fail in the last 17 days, plus it's not reproducible locally. I am going to close this for now.

@piergm piergm closed this as completed Jan 24, 2025
@thecoop
Copy link
Member

thecoop commented Feb 17, 2025

A similar failure happened - https://gradle-enterprise.elastic.co/s/jlasxj7sgru44/console-log?anchor=20165&page=21. Doesn't reproduce locally, but looks like it may be an intermittent issue?

@javanna
Copy link
Member

javanna commented Apr 1, 2025

Seen another one today in 8.18:

REPRODUCE WITH: ./gradlew ":x-pack:plugin:searchable-snapshots:internalClusterTest" --tests "org.elasticsearch.xpack.searchablesnapshots.SearchableSnapshotsIntegTests.testCreateAndRestoreSearchableSnapshot" -Dtests.seed=4A4B064A5713CE1C -Dtests.locale=ar-LB -Dtests.timezone=America/Belem -Druntime.java=24
  2> java.lang.AssertionError: Index{id='Ljkcprlviy/0TLjdQ4GSnSUnpZROdaN4g/aPHX5oqsTPSmMh42ODqE-A/7/_0.cfs/@2232', seqNo=193, primaryTerm=1, version=1, autoGeneratedIdTimestamp=-1}
    Expected: <2L>
         but: was <1L>
        at __randomizedtesting.SeedInfo.seed([4A4B064A5713CE1C:C0287131C4849FAF]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.elasticsearch.test.ESTestCase.assertThat(ESTestCase.java:2617)
        at org.elasticsearch.index.engine.EngineTestCase.assertConsistentHistoryBetweenTranslogAndLuceneIndex(EngineTestCase.java:1378)
        at org.elasticsearch.index.shard.IndexShardTestCase.assertConsistentHistoryBetweenTranslogAndLucene(IndexShardTestCase.java:987)
        at org.elasticsearch.test.InternalTestCluster.assertConsistentHistoryBetweenTranslogAndLuceneIndex(InternalTestCluster.java:1409)
        at org.elasticsearch.snapshots.AbstractSnapshotIntegTestCase.assertConsistentHistoryInLuceneIndex(AbstractSnapshotIntegTestCase.java:131)

Relabelling this as well because from the assertion that fails, this does not seem to be a search problem.

@javanna javanna reopened this Apr 1, 2025
@javanna javanna added :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. needs:risk Requires assignment of a risk label (low, medium, blocker) and removed :Search Foundations/Search Catch all for Search Foundations low-risk An open issue or test failure that is a low risk to future releases labels Apr 1, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Indexing Meta label for Distributed Indexing team label Apr 1, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

@elasticsearchmachine elasticsearchmachine removed the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Apr 1, 2025
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 2 failures in test testCreateAndRestoreSearchableSnapshot (0.7% fail rate in 273 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Apr 3, 2025
…ntegTests testCreateAndRestoreSearchableSnapshot #119709
@albertzaharovits albertzaharovits added medium-risk An open issue or test failure that is a medium risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Apr 9, 2025
andreidan pushed a commit to andreidan/elasticsearch that referenced this issue Apr 9, 2025
@arteam
Copy link
Contributor

arteam commented Apr 15, 2025

I'm going to reassign this issue to `:StorageEngine/Logs, since the assertion started failing after the translog operation assertions changes in #119330. This test seems to failing on checking the primary terms of the lucene ops and translog ops, and is not fail on synthetic source assertions, but I wonder if #119330 had some side-effects.

@arteam arteam added :StorageEngine/Logs You know, for Logs and removed :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. labels Apr 15, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine elasticsearchmachine removed the Team:Distributed Indexing Meta label for Distributed Indexing team label Apr 15, 2025
@arteam
Copy link
Contributor

arteam commented Apr 15, 2025

Maybe we need to supply TranslogOperationAsserter.withEngineConfig(config) in ReadOnlyEngine instead of TranslogOperationAsserter.DEFAULT

@lkts
Copy link
Contributor

lkts commented Apr 21, 2025

It looks like it fails here meaning primary term somehow does not match?

https://github.com/elastic/elasticsearch/blob/main/test/framework/src/main/java/org/elasticsearch/index/engine/EngineTestCase.java#L1400

Note that in order to get to this line the engine must be an InternalEngine.

@lkts
Copy link
Contributor

lkts commented Apr 21, 2025

I don't believe this is related to #119330 since it was failing before as well https://es-delivery-stats.elastic.dev/app/r/s/sD7Lr.

@lkts
Copy link
Contributor

lkts commented Apr 21, 2025

The only somewhat notable thing i can see is that the document from the assert seems to be from the .snapshot-blob-cache index.

@lkts
Copy link
Contributor

lkts commented Apr 21, 2025

I have opened #127131 which may or may not be helpful. Given that it does not look like it's related to #119330 i'll assign it back.

@lkts lkts added :Distributed Indexing/Searchable Snapshots Searchable snapshots / frozen indices. and removed Team:StorageEngine :StorageEngine/Logs You know, for Logs labels Apr 21, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Indexing Meta label for Distributed Indexing team label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Searchable Snapshots Searchable snapshots / frozen indices. medium-risk An open issue or test failure that is a medium risk to future releases Team:Distributed Indexing Meta label for Distributed Indexing team >test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests

7 participants