Skip to content

ParseIpTests.testLeadingZerosAreOctal failing #126484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alex-spies opened this issue Apr 8, 2025 · 5 comments
Closed

ParseIpTests.testLeadingZerosAreOctal failing #126484

alex-spies opened this issue Apr 8, 2025 · 5 comments
Assignees
Labels
:Analytics/ES|QL AKA ESQL low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@alex-spies
Copy link
Contributor

alex-spies commented Apr 8, 2025

CI Link

https://gradle-enterprise.elastic.co/s/7xw7goreqzvkg/tests/task/:x-pack:plugin:esql:test/details/org.elasticsearch.xpack.esql.expression.function.scalar.convert.ParseIpTests/testLeadingZerosAreOctal%20%7BTestCase%5Bstr%3Dv4%2C%20validLeadingZerosRejected%3Dtrue%2C%20validLeadingZerosAreDecimal%3Dtrue%2C%20validLeadingZerosAreOctal%3Dtrue%5D%7D?top-execution=1

Repro line

./gradlew ":x-pack:plugin:esql:test" --tests "org.elasticsearch.xpack.esql.expression.function.scalar.convert.ParseIpTests.testLeadingZerosAreOctal {TestCase[str=v4, validLeadingZerosRejected=true, validLeadingZerosAreDecimal=true, validLeadingZerosAreOctal=true]}" -Dtests.seed=4E9DFA270335688A -Dtests.locale=nyn -Dtests.timezone=PST -Druntime.java=24	

Does it reproduce?

Yes

Applicable branches

8.x

Failure history

No response

Failure excerpt

java.lang.AssertionError: 	
Expected: <[0 0 0 0 0 0 0 0 0 0 ff ff 0 17 6f 7a]>	
     but: was <[0 0 0 0 0 0 0 0 0 0 ff ff 0 1b 9d ac]>	
at __randomizedtesting.SeedInfo.seed([4E9DFA270335688A:8937DA60C418AE6E]:0)	
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)	
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)	
at org.elasticsearch.test.ESTestCase.assertThat(ESTestCase.java:2637)	
at org.elasticsearch.xpack.esql.expression.function.scalar.convert.ParseIpTests.success(ParseIpTests.java:133)	
at org.elasticsearch.xpack.esql.expression.function.scalar.convert.ParseIpTests.testLeadingZerosAreOctal(ParseIpTests.java:125)	
at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)	
at java.lang.reflect.Method.invoke(Method.java:565)	
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1763)	
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)	
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)	
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)	
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)	
at org.junit.rules.RunRules.evaluate(RunRules.java:20)	
at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)	
at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)	
at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)	
at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)	
at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)	
at org.junit.rules.RunRules.evaluate(RunRules.java:20)	
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)	
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)	
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)	
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)	
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)	
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)	
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)	
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)	
at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)	
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)	
at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)	
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)	
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)	
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)	
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)	
at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)	
at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)	
at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)	
at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)	
at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)	
at org.junit.rules.RunRules.evaluate(RunRules.java:20)	
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)	
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)	
at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)	
at java.lang.Thread.run(Thread.java:1447)
@alex-spies alex-spies added >test-failure Triaged test failures from CI needs:triage Requires assignment of a team area label :Analytics/ES|QL AKA ESQL needs:risk Requires assignment of a risk label (low, medium, blocker) and removed needs:triage Requires assignment of a team area label labels Apr 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 8, 2025
@alex-spies
Copy link
Contributor Author

alex-spies commented Apr 8, 2025

@nik9000 , got a reproducible failure from a PR's CI run; confirmed reproducing on current 8.x. This test was added by a PR from you today; would you like to take a look?

@nik9000
Copy link
Member

nik9000 commented Apr 8, 2025

Got it!

@nik9000 nik9000 added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Apr 8, 2025
@nik9000
Copy link
Member

nik9000 commented Apr 8, 2025

The octal stuff isn't plugged in to production yet. Super low risk.

@alex-spies
Copy link
Contributor Author

The CI bot picked this by now. Closing in favor of #126496 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests

3 participants