Skip to content

[CI] ParseIpTests testLeadingZerosAreOctal {TestCase[str=v4, validLeadingZerosRejected=true, validLeadingZerosAreDecimal=true, validLeadingZerosAreOctal=true]} failing #126496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elasticsearchmachine opened this issue Apr 8, 2025 · 4 comments · Fixed by #126552
Closed

[CI] ParseIpTests testLeadingZerosAreOctal {TestCase[str=v4, validLeadingZerosRejected=true, validLeadingZerosAreDecimal=true, validLeadingZerosAreOctal=true]} failing #126496

elasticsearchmachine opened this issue Apr 8, 2025 · 4 comments · Fixed by #126552
Assignees
@nik9000
Labels
:Analytics/ES|QL AKA ESQL low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 8, 2025 •
edited
Loading

Build Scans:

Reproduction Line:

./gradlew ":x-pack:plugin:esql:test" --tests "org.elasticsearch.xpack.esql.expression.function.scalar.convert.ParseIpTests.testLeadingZerosAreOctal {TestCase[str=v4, validLeadingZerosRejected=true, validLeadingZerosAreDecimal=true, validLeadingZerosAreOctal=true]}" -Dtests.seed=FA865C2C84E9BA3E -Dtests.locale=shi-Tfng -Dtests.timezone=Europe/Brussels -Druntime.java=24

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: 
Expected: <[0 0 0 0 0 0 0 0 0 0 ff ff 0 6d 87 46]>
     but: was <[0 0 0 0 0 0 0 0 0 0 ff ff 0 9b cf 6a]>

Issue Reasons:

  • [main] 8 failures in test testLeadingZerosAreOctal {TestCase[str=v4, validLeadingZerosRejected=true, validLeadingZerosAreDecimal=true, validLeadingZerosAreOctal=true]} (2.0% fail rate in 403 executions)
  • [main] 4 failures in step part-3 (2.2% fail rate in 185 executions)
  • [main] 2 failures in step part3 (3.5% fail rate in 57 executions)
  • [main] 2 failures in pipeline elasticsearch-periodic-platform-support (33.3% fail rate in 6 executions)
  • [main] 4 failures in pipeline elasticsearch-pull-request (2.2% fail rate in 181 executions)
  • [main] 2 failures in pipeline elasticsearch-intake (3.5% fail rate in 57 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Analytics/ES|QL AKA ESQL >test-failure Triaged test failures from CI labels Apr 8, 2025
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch 9.0

Mute Reasons:

  • [9.0] 2 failures in test testLeadingZerosAreOctal {TestCase[str=v4, validLeadingZerosRejected=true, validLeadingZerosAreDecimal=true, validLeadingZerosAreOctal=true]} (10.5% fail rate in 19 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Apr 8, 2025
@elasticsearchmachine
Mute org.elasticsearch.xpack.esql.expression.function.scalar.convert.…
0d7b961 
…ParseIpTests testLeadingZerosAreOctal {TestCase[str=v4, validLeadingZerosRejected=true, validLeadingZerosAreDecimal=true, validLeadingZerosAreOctal=true]} #126496
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) needs:risk Requires assignment of a risk label (low, medium, blocker) labels Apr 8, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-analytical-engine (Team:Analytics)

@alex-spies alex-spies added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Apr 9, 2025
@alex-spies
Copy link
Contributor

Had this in a PR before, too, so here goes another build scan: https://gradle-enterprise.elastic.co/s/7xw7goreqzvkg

@alex-spies alex-spies marked this as a duplicate of #126484 Apr 9, 2025
@alex-spies alex-spies mentioned this issue Apr 9, 2025
Closed
@nik9000
Copy link
Member

nik9000 commented Apr 9, 2025

Grr. I forgot abou tthis one. Will start it now.

nik9000 added a commit to nik9000/elasticsearch that referenced this issue Apr 9, 2025
@nik9000
ESQL: Fix bug in octal ip parsing tests
f24ec9e 
This fixes a bug in the tests for parsing ipv4 addresses with leading
zeros as octal numbers. The bug was in the expectation code that we use
for random input ips.

Closes elastic#126496
@nik9000 nik9000 mentioned this issue Apr 9, 2025
Merged
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Apr 9, 2025
@nik9000
ESQL: Fix bug in octal ip parsing tests (elastic#126552)
dc81685 
This fixes a bug in the tests for parsing ipv4 addresses with leading
zeros as octal numbers. The bug was in the expectation code that we use
for random input ips.

Closes elastic#126496
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Apr 9, 2025
@nik9000
ESQL: Fix bug in octal ip parsing tests (elastic#126552)
a107343 
This fixes a bug in the tests for parsing ipv4 addresses with leading
zeros as octal numbers. The bug was in the expectation code that we use
for random input ips.

Closes elastic#126496
elasticsearchmachine pushed a commit that referenced this issue Apr 10, 2025
@nik9000
ESQL: Fix bug in octal ip parsing tests (#126552) (#126574)
520971c 
This fixes a bug in the tests for parsing ipv4 addresses with leading
zeros as octal numbers. The bug was in the expectation code that we use
for random input ips.

Closes #126496
elasticsearchmachine pushed a commit that referenced this issue Apr 10, 2025
@nik9000
ESQL: Fix bug in octal ip parsing tests (#126552) (#126575)
cf2e7f8 
This fixes a bug in the tests for parsing ipv4 addresses with leading
zeros as octal numbers. The bug was in the expectation code that we use
for random input ips.

Closes #126496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
:Analytics/ES|QL AKA ESQL low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESQL: Fix bug in octal ip parsing tests nik9000/elasticsearch
3 participants
@nik9000 @elasticsearchmachine @alex-spies