Skip to content

FORK: allow more commands in FORK branches #126553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 3 tasks
Tracked by #121652
ioanatia opened this issue Apr 9, 2025 · 2 comments
Open
1 of 3 tasks
Tracked by #121652

FORK: allow more commands in FORK branches #126553

ioanatia opened this issue Apr 9, 2025 · 2 comments
Labels
ES|QL-ui Impacts ES|QL UI >feature :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0

Comments

@ioanatia
Copy link
Contributor

ioanatia commented Apr 9, 2025 •
edited
Loading

Tracked in #121652
At the moment FORK branches can only allow WHERE/LIMIT/SORT commands.

We want to remove this restriction, allowing FORK branches to support (almost) all commands.

One of the commands for which we know we will continue to have a restriction is the case of having a FORK commands inside another FORK branch.
This will be disallowed for the moment.

  • FORK - allow EVAL/DISSECT/STATS in branches #125937 (just opens up support for DISSECT/STATS and EVAL)
  • open up support such that we allow the rest of the commands in FORK branches
  • add proper validation for the ones that we won't support (e.g. FORK within a FORK)
@ioanatia ioanatia added :Search Relevance/Search Catch all for Search Relevance >feature ES|QL-ui Impacts ES|QL UI Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0 labels Apr 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/kibana-esql (ES|QL-ui)

This was referenced Apr 9, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ES|QL-ui Impacts ES|QL UI >feature :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ioanatia @elasticsearchmachine