Skip to content

[CI] AddStringKeyStoreCommandTests testStdinWithMultipleValues failing #126882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elasticsearchmachine opened this issue Apr 15, 2025 · 2 comments · Fixed by #126966
Closed

[CI] AddStringKeyStoreCommandTests testStdinWithMultipleValues failing #126882

elasticsearchmachine opened this issue Apr 15, 2025 · 2 comments · Fixed by #126966
Labels
:Core/Infra/CLI CLI utilities, scripts, and infrastructure needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 15, 2025 •
edited
Loading

Build Scans:

Reproduction Line:

gradlew ":distribution:tools:keystore-cli:test" --tests "org.elasticsearch.cli.keystore.AddStringKeyStoreCommandTests.testStdinWithMultipleValues" -Dtests.seed=144BEC9F7A965E66 -Dtests.locale=kn -Dtests.timezone=Etc/GMT0 -Druntime.java=24

Applicable branches:
9.0

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

org.junit.ComparisonFailure: expected:<[bar2]> but was:<[]>

Issue Reasons:

  • [9.0] 3 consecutive failures in step windows-2022_checkpart1_platform-support-windows
  • [9.0] 3 failures in test testStdinWithMultipleValues (3.8% fail rate in 80 executions)
  • [9.0] 3 failures in step windows-2022_checkpart1_platform-support-windows (75.0% fail rate in 4 executions)
  • [9.0] 3 failures in pipeline elasticsearch-periodic-platform-support (75.0% fail rate in 4 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Core/Infra/CLI CLI utilities, scripts, and infrastructure >test-failure Triaged test failures from CI Team:Core/Infra Meta label for core/infra team needs:risk Requires assignment of a risk label (low, medium, blocker) labels Apr 15, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-core-infra (Team:Core/Infra)

rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 16, 2025
@rjernst
Use Terminal.readSecret in add string keystore command
d33c3a6 
As a followon to elastic#126729, the add string keystore command doesn't need
to use a reader at all (and it was incorrect for it to close the reader
from the terminal). Instead, the Terminal abstraction already handles
how to get at line by line secrets. This commit removes that usage of
reader and uses readSecret calls instead.

closes elastic#126882
@rjernst rjernst mentioned this issue Apr 16, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 4 consecutive failures in step windows-2022_checkpart1_platform-support-windows
  • [main] 5 failures in test testStdinWithMultipleValues (2.0% fail rate in 248 executions)
  • [main] 4 failures in step windows-2022_checkpart1_platform-support-windows (100.0% fail rate in 4 executions)
  • [main] 4 failures in pipeline elasticsearch-periodic-platform-support (80.0% fail rate in 5 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Apr 16, 2025
@elasticsearchmachine
Mute org.elasticsearch.cli.keystore.AddStringKeyStoreCommandTests tes…
1c9ff3a 
…tStdinWithMultipleValues #126882
rjernst added a commit that referenced this issue Apr 18, 2025
@rjernst
Use Terminal.readSecret in add string keystore command (#126966)
584b237 
As a followon to #126729, the add string keystore command doesn't need
to use a reader at all (and it was incorrect for it to close the reader
from the terminal). Instead, the Terminal abstraction already handles
how to get at line by line secrets. This commit removes that usage of
reader and uses readSecret calls instead.

closes #126882
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 18, 2025
@rjernst
Use Terminal.readSecret in add string keystore command (elastic#126966)
0fd829d 
As a followon to elastic#126729, the add string keystore command doesn't need
to use a reader at all (and it was incorrect for it to close the reader
from the terminal). Instead, the Terminal abstraction already handles
how to get at line by line secrets. This commit removes that usage of
reader and uses readSecret calls instead.

closes elastic#126882
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 18, 2025
@rjernst
Use Terminal.readSecret in add string keystore command (elastic#126966)
6b01493 
As a followon to elastic#126729, the add string keystore command doesn't need
to use a reader at all (and it was incorrect for it to close the reader
from the terminal). Instead, the Terminal abstraction already handles
how to get at line by line secrets. This commit removes that usage of
reader and uses readSecret calls instead.

closes elastic#126882
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 18, 2025
@rjernst
Use Terminal.readSecret in add string keystore command (elastic#126966)
0762e52 
As a followon to elastic#126729, the add string keystore command doesn't need
to use a reader at all (and it was incorrect for it to close the reader
from the terminal). Instead, the Terminal abstraction already handles
how to get at line by line secrets. This commit removes that usage of
reader and uses readSecret calls instead.

closes elastic#126882
elasticsearchmachine pushed a commit that referenced this issue Apr 18, 2025
@rjernst
Use Terminal.readSecret in add string keystore command (#126966) (#12…
16cd8a2 
…7069)

As a followon to #126729, the add string keystore command doesn't need
to use a reader at all (and it was incorrect for it to close the reader
from the terminal). Instead, the Terminal abstraction already handles
how to get at line by line secrets. This commit removes that usage of
reader and uses readSecret calls instead.

closes #126882
elasticsearchmachine pushed a commit that referenced this issue Apr 18, 2025
@rjernst
Use Terminal.readSecret in add string keystore command (#126966) (#12…
a809fd7 
…7070)

As a followon to #126729, the add string keystore command doesn't need
to use a reader at all (and it was incorrect for it to close the reader
from the terminal). Instead, the Terminal abstraction already handles
how to get at line by line secrets. This commit removes that usage of
reader and uses readSecret calls instead.

closes #126882
elasticsearchmachine pushed a commit that referenced this issue Apr 18, 2025
@rjernst
Use Terminal.readSecret in add string keystore command (#126966) (#12…
57bb5f3 
…7068)

As a followon to #126729, the add string keystore command doesn't need
to use a reader at all (and it was incorrect for it to close the reader
from the terminal). Instead, the Terminal abstraction already handles
how to get at line by line secrets. This commit removes that usage of
reader and uses readSecret calls instead.

closes #126882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/CLI CLI utilities, scripts, and infrastructure needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Terminal.readSecret in add string keystore command rjernst/elasticsearch
1 participant
@elasticsearchmachine