Skip to content

[CI] AddStringKeyStoreCommandTests testStdinInputWithCarriageReturn failing #127089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elasticsearchmachine opened this issue Apr 19, 2025 · 1 comment · Fixed by #127094
Closed

[CI] AddStringKeyStoreCommandTests testStdinInputWithCarriageReturn failing #127089

elasticsearchmachine opened this issue Apr 19, 2025 · 1 comment · Fixed by #127094
Labels
:Core/Infra/CLI CLI utilities, scripts, and infrastructure low-risk An open issue or test failure that is a low risk to future releases Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 19, 2025 •
edited
Loading

Build Scans:

Reproduction Line:

gradlew ":distribution:tools:keystore-cli:test" --tests "org.elasticsearch.cli.keystore.AddStringKeyStoreCommandTests.testStdinInputWithCarriageReturn" -Dtests.seed=B3841538AEE5F8A9 -Dtests.locale=sd-Arab -Dtests.timezone=Turkey -Druntime.java=24

Applicable branches:
9.0

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

org.junit.ComparisonFailure: expected:<Typedthisandhitenter[]> but was:<Typedthisandhitenter[
]>

Issue Reasons:

  • [9.0] 8 consecutive failures in step windows-2022_checkpart1_platform-support-windows
  • [9.0] 8 failures in test testStdinInputWithCarriageReturn (3.8% fail rate in 209 executions)
  • [9.0] 8 failures in step windows-2022_checkpart1_platform-support-windows (100.0% fail rate in 8 executions)
  • [9.0] 8 failures in pipeline elasticsearch-periodic-platform-support (88.9% fail rate in 9 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Core/Infra/CLI CLI utilities, scripts, and infrastructure >test-failure Triaged test failures from CI Team:Core/Infra Meta label for core/infra team needs:risk Requires assignment of a risk label (low, medium, blocker) labels Apr 19, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-core-infra (Team:Core/Infra)

rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 19, 2025
@rjernst
Use explicit newline with keystore stdin test
111fc30 
The add string keystore command accepts input on stdin. In this case,
the terminal is responsible for separating input by newlines that are
system dependent. The mock terminal normally adds the system dependent
newline. However, we also have tests that ensure both unix and windows
style newlines are tested explicitly. This commit fixes the windows
style carriage returns to explicitly contain a newline.

closes elastic#127089
@rjernst rjernst mentioned this issue Apr 19, 2025
Merged
@rjernst rjernst added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Apr 19, 2025
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 21, 2025
@rjernst
Use explicit newline with keystore stdin test (elastic#127094)
e64e08a 
The add string keystore command accepts input on stdin. In this case,
the terminal is responsible for separating input by newlines that are
system dependent. The mock terminal normally adds the system dependent
newline. However, we also have tests that ensure both unix and windows
style newlines are tested explicitly. This commit fixes the windows
style carriage returns to explicitly contain a newline.

closes elastic#127089
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 21, 2025
@rjernst
Use explicit newline with keystore stdin test (elastic#127094)
e9a36b6 
The add string keystore command accepts input on stdin. In this case,
the terminal is responsible for separating input by newlines that are
system dependent. The mock terminal normally adds the system dependent
newline. However, we also have tests that ensure both unix and windows
style newlines are tested explicitly. This commit fixes the windows
style carriage returns to explicitly contain a newline.

closes elastic#127089
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 21, 2025
@rjernst
Use explicit newline with keystore stdin test (elastic#127094)
2522a34 
The add string keystore command accepts input on stdin. In this case,
the terminal is responsible for separating input by newlines that are
system dependent. The mock terminal normally adds the system dependent
newline. However, we also have tests that ensure both unix and windows
style newlines are tested explicitly. This commit fixes the windows
style carriage returns to explicitly contain a newline.

closes elastic#127089
elasticsearchmachine pushed a commit that referenced this issue Apr 21, 2025
@rjernst
Use explicit newline with keystore stdin test (#127094) (#127130)
d92625e 
The add string keystore command accepts input on stdin. In this case,
the terminal is responsible for separating input by newlines that are
system dependent. The mock terminal normally adds the system dependent
newline. However, we also have tests that ensure both unix and windows
style newlines are tested explicitly. This commit fixes the windows
style carriage returns to explicitly contain a newline.

closes #127089
elasticsearchmachine pushed a commit that referenced this issue Apr 21, 2025
@rjernst
Use explicit newline with keystore stdin test (#127094) (#127129)
0280657 
The add string keystore command accepts input on stdin. In this case,
the terminal is responsible for separating input by newlines that are
system dependent. The mock terminal normally adds the system dependent
newline. However, we also have tests that ensure both unix and windows
style newlines are tested explicitly. This commit fixes the windows
style carriage returns to explicitly contain a newline.

closes #127089
elasticsearchmachine pushed a commit that referenced this issue Apr 21, 2025
@rjernst
Use explicit newline with keystore stdin test (#127094) (#127128)
e79d033 
The add string keystore command accepts input on stdin. In this case,
the terminal is responsible for separating input by newlines that are
system dependent. The mock terminal normally adds the system dependent
newline. However, we also have tests that ensure both unix and windows
style newlines are tested explicitly. This commit fixes the windows
style carriage returns to explicitly contain a newline.

closes #127089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/CLI CLI utilities, scripts, and infrastructure low-risk An open issue or test failure that is a low risk to future releases Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use explicit newline with keystore stdin test rjernst/elasticsearch
2 participants
@rjernst @elasticsearchmachine