Skip to content

Remove dependency on waiting for master in cluster state API in tests #127212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nielsbauman opened this issue Apr 23, 2025 · 1 comment
Open

Remove dependency on waiting for master in cluster state API in tests #127212

nielsbauman opened this issue Apr 23, 2025 · 1 comment
Assignees
@nielsbauman
Labels
:Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests

Comments

@nielsbauman
Copy link
Contributor

Currently, several tests depend on the cluster state API to wait for a master node to be present in the cluster state - see this snippet in SpecificMasterNodesIT for example.

To allow TransportClusterStateAction to run on the local node (as part of #101805), we are removing the functionality of waiting for the master node. Therefore, we need to remove the dependency of these tests on that functionality. Addtionally, the cluster state API is not supposed to be used in production, meaning that these tests are the only real use case for waiting on the master node. We have different tools available in the test framework that allow us to wait for the master node.
@nielsbauman nielsbauman added :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. >test Issues or PRs that are addressing/adding tests Team:Distributed Coordination Meta label for Distributed Coordination team labels Apr 23, 2025
@nielsbauman nielsbauman self-assigned this Apr 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

nielsbauman added a commit to nielsbauman/elasticsearch that referenced this issue Apr 23, 2025
@nielsbauman
Remove dependency on cluster state API in SpecificMasterNodesIT
83dd3f8 
These tests depended on the cluster state API to wait for the master
node. This behavior is being removed, so we switch to alternative
approaches of waiting for the master node.

Relates elastic#127212
nielsbauman added a commit to nielsbauman/elasticsearch that referenced this issue Apr 23, 2025
@nielsbauman
Remove dependency on cluster state API in SpecificMasterNodesIT
1dd9d03 
These tests depended on the cluster state API to wait for the master
node. This behavior is being removed, so we switch to alternative
approaches of waiting for the master node.

Relates elastic#127212
nielsbauman added a commit to nielsbauman/elasticsearch that referenced this issue Apr 23, 2025
@nielsbauman
Remove dependency on cluster state API in SpecificMasterNodesIT
186faee 
These tests depended on the cluster state API to wait for the master
node. This behavior is being removed, so we switch to alternative
approaches of waiting for the master node.

Relates elastic#127212
@nielsbauman nielsbauman mentioned this issue Apr 23, 2025
Merged
nielsbauman added a commit that referenced this issue Apr 25, 2025
@nielsbauman
Remove dependency on cluster state API in SpecificMasterNodesIT (#1…
7bd2b80 
…27213)

These tests depended on the cluster state API to wait for the master
node. This behavior is being removed, so we switch to alternative
approaches of waiting for the master node.

Relates #127212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nielsbauman nielsbauman

Labels
:Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nielsbauman @elasticsearchmachine