Skip to content

[CI] PushQueriesIT testPushCaseInsensitiveEqualityOnDefaults failing #127431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elasticsearchmachine opened this issue Apr 26, 2025 · 3 comments · Fixed by #127532
Closed

[CI] PushQueriesIT testPushCaseInsensitiveEqualityOnDefaults failing #127431

elasticsearchmachine opened this issue Apr 26, 2025 · 3 comments · Fixed by #127532
Assignees
@nik9000
Labels
:Analytics/ES|QL AKA ESQL low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

Build Scans:

Reproduction Line:

./gradlew ":x-pack:plugin:esql:qa:server:single-node:javaRestTest" --tests "org.elasticsearch.xpack.esql.qa.single_node.PushQueriesIT.testPushCaseInsensitiveEqualityOnDefaults" -Dtests.seed=3458C8C42AC19307 -Dtests.locale=ar-QA -Dtests.timezone=Etc/Greenwich -Druntime.java=21 -Dtests.fips.enabled=true

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: Expected a map containing
documents_found: <1>
  values_loaded: <1>
           took: <48>
     is_partial: <false>
        profile: a map containing
          drivers: <[{cluster_name=test-cluster, sleeps={last=[], counts={}, first=[]}, cpu_nanos=1283719, operators=[{operator=LuceneSourceOperator[shards = [test:0], maxPageSize = 4854, remainingDocs = 2147483646], status={processed_slices=1, processed_shards=[test:0], total_slices=1, slice_max=0, current=2147483647, slice_min=0, rows_emitted=1, pages_emitted=1, process_nanos=146713, partitioning_strategies={test:0=SHARD}, processed_queries=[*:*], slice_index=0}}, {operator=ValuesSourceReaderOperator[fields = [test]], status={pages_processed=1, rows_emitted=1, process_nanos=761488, rows_received=1, readers_built={test:column_at_a_time:null=1, stored_fields[requires_source:true, fields:0, sequential: false]=1, test:row_stride:BlockSourceReader.Bytes=1}, values_loaded=1}}, {operator=FilterOperator[evaluator=Insens
[truncated]

Issue Reasons:

  • [main] 3 failures in test testPushCaseInsensitiveEqualityOnDefaults (0.5% fail rate in 610 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Analytics/ES|QL AKA ESQL >test-failure Triaged test failures from CI labels Apr 26, 2025
elasticsearchmachine added a commit that referenced this issue Apr 26, 2025
@elasticsearchmachine
Mute org.elasticsearch.xpack.esql.qa.single_node.PushQueriesIT testPu…
8e3810c 
…shCaseInsensitiveEqualityOnDefaults #127431
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 3 failures in test testPushCaseInsensitiveEqualityOnDefaults (0.5% fail rate in 610 executions)

Build Scans:

@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) needs:risk Requires assignment of a risk label (low, medium, blocker) labels Apr 26, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-analytical-engine (Team:Analytics)

benchaplin pushed a commit to benchaplin/elasticsearch that referenced this issue Apr 28, 2025
@elasticsearchmachine @benchaplin
Mute org.elasticsearch.xpack.esql.qa.single_node.PushQueriesIT testPu…
6a888c2 
…shCaseInsensitiveEqualityOnDefaults elastic#127431
@nik9000 nik9000 self-assigned this Apr 29, 2025
@nik9000 nik9000 added the low-risk An open issue or test failure that is a low risk to future releases label Apr 29, 2025
@elasticsearchmachine elasticsearchmachine removed the needs:risk Requires assignment of a risk label (low, medium, blocker) label Apr 29, 2025
@nik9000
Copy link
Member

nik9000 commented Apr 29, 2025

The problem is the case insensitive equals doesn't match the empty string. Checking if that's an ESQL bug or an everything bug.

nik9000 added a commit to nik9000/elasticsearch that referenced this issue Apr 29, 2025
@nik9000
ESQL: Fix case insensitive comparisons to ""
55e144b 
This fixes the compute engine side of case insensitive ==. You can
trigger it by writing:
```
FROM foo
| WHERE TO_LOWER(field) == ""
```

But *only* when we can't push the comparison to lucene - like if `field`
is not indexed or is a `text` field.

Closes elastic#127431
@nik9000 nik9000 mentioned this issue Apr 29, 2025
Merged
nik9000 added a commit that referenced this issue Apr 30, 2025
@nik9000 @elasticsearchmachine
ESQL: Fix case insensitive comparisons to "" (#127532)
4494fdc 
This fixes the compute engine side of case insensitive ==. You can
trigger it by writing:
```
FROM foo
| WHERE TO_LOWER(field) == ""
```

But *only* when we can't push the comparison to lucene - like if `field`
is not indexed or is a `text` field.

Closes #127431


* revert mute change

* more revert

---------

Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
:Analytics/ES|QL AKA ESQL low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESQL: Fix case insensitive comparisons to "" nik9000/elasticsearch
2 participants
@nik9000 @elasticsearchmachine