Skip to content

Transport versions are mixed up #127667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nik9000 opened this issue May 2, 2025 · 1 comment · Fixed by #127668
Closed

Transport versions are mixed up #127667

nik9000 opened this issue May 2, 2025 · 1 comment · Fixed by #127668
Assignees
@nik9000
Labels
blocker >bug needs:triage Requires assignment of a team area label

Comments

@nik9000
Copy link
Member

nik9000 commented May 2, 2025

Description

Here's main:

    public static final TransportVersion ESQL_REPORT_ORIGINAL_TYPES_BACKPORT_8_19 = def(8_841_0_22);
    public static final TransportVersion INTRODUCE_FAILURES_LIFECYCLE_BACKPORT_8_19 = def(8_841_0_23);
    public static final TransportVersion V_9_0_0 = def(9_000_0_09);

Here's 8.19:

    public static final TransportVersion ESQL_REPORT_ORIGINAL_TYPES_BACKPORT_8_19 = def(8_841_0_22);
    public static final TransportVersion PINNED_RETRIEVER_8_19 = def(8_841_0_23);
    public static final TransportVersion ESQL_AGGREGATE_METRIC_DOUBLE_BLOCK_8_19 = def(8_841_0_24);

These aren't compatible with one another and main can't rolling upgrade from 8.19 at the moment.
@nik9000 nik9000 added >enhancement needs:triage Requires assignment of a team area label >bug blocker and removed >enhancement needs:triage Requires assignment of a team area label labels May 2, 2025
@nik9000 nik9000 self-assigned this May 2, 2025
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label May 2, 2025
@nik9000
Copy link
Member Author

nik9000 commented May 2, 2025

@limotova, @mridula-s109, and @gmarouli , there's been a transport version mixup. I'll try to resolve it, but I'm not sure I'll manage tonight.

Here's what happened, so far as I can tell.

Elasticsearch main can't form a cluster with 8.19 because it thinks the changes associated with 127633 are back - but they are not. Instead 127639 and 127623 are.

I'm going to try and brain main into compatibility with 8.19 by modifying main only because I think that'll be less work. To do that, I'm taking the number claimed by 127633 and giving it to 127639. Then I'm adding support to main for 127623.

nik9000 added a commit to nik9000/elasticsearch that referenced this issue May 2, 2025
@nik9000
ESQL: Fix transport versions
2c93edc 
In elastic#127623 we backported elastic#127299 and added a backport transport version
for it - `ESQL_AGGREGATE_METRIC_DOUBLE_BLOCK_8_19` aka `8_841_0_24`.
This brings that version forwards to `main` and adds support for parsing
streams with that version.

In elastic#127639 we backported elastic#126401 and added a backport transport version
for it - `PINNED_RETRIEVER_8_19` aka `8_841_0_23`. This brings that
version forwards to `main` and adds support for parsing streams with
that versions.

In elastic#127633 we a claimed a backport transport version to backport elastic#127314 -
`INTRODUCE_FAILURES_LIFECYCLE_BACKPORT_8_19` aka `8_841_0_23`. That's
the same versions as `PINNED_RETRIEVER_8_19`. It's just that this one is
in `main` and `PINNED_RETRIEVER_8_19` is in `8.19`. To allow me to bring
`PINNED_RETRIEVER_8_19` for wards I've had to revert elastic#127633.

Closes elastic#127667
@nik9000 nik9000 mentioned this issue May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
blocker >bug needs:triage Requires assignment of a team area label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESQL: Fix transport versions nik9000/elasticsearch
2 participants
@nik9000 @elasticsearchmachine