Skip to content

Add useful toString() to Scripting's DynamicMap #70262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stu-elastic opened this issue Mar 10, 2021 · 3 comments · Fixed by #126562
Closed

Add useful toString() to Scripting's DynamicMap #70262

stu-elastic opened this issue Mar 10, 2021 · 3 comments · Fixed by #126562
Assignees
@jdconrad
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team triaged Issue has been looked at, and is being left open

Comments

@stu-elastic
Copy link
Contributor

stu-elastic commented Mar 10, 2021 •
edited
Loading

If one Debug.explain(map)s a DynamicMap, the toString does not reveal the contents of the map.
@stu-elastic stu-elastic added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Mar 10, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Mar 10, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst rjernst added good first issue low hanging fruit triaged Issue has been looked at, and is being left open labels Apr 4, 2025
@esousacosta
Copy link
Contributor

Hello @jdconrad, are you currently working on this? Checking to avoid working on someone else's issue

@jdconrad
Copy link
Contributor

jdconrad commented Apr 9, 2025

@esousacosta I do plan to work on this. Thank you for checking.

@jdconrad jdconrad removed the good first issue low hanging fruit label Apr 9, 2025
@jdconrad jdconrad mentioned this issue Apr 9, 2025
Merged
jdconrad added a commit that referenced this issue Apr 11, 2025
@jdconrad
Add a custom toString to DynamicMap (#126562)
8563235 
This change prevents a delegate map from giving an inconsistent 
toString or an empty toString.

Closes #70262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdconrad jdconrad

Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team triaged Issue has been looked at, and is being left open
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a custom toString to DynamicMap jdconrad/elasticsearch
5 participants
@rjernst @jdconrad @elasticmachine @esousacosta @stu-elastic