-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[CI] S3BlobStoreRepositoryTests testRequestStats failing #88841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pinging @elastic/es-distributed (Team:Distributed) |
…ts#testRequestStats Relates elastic#88841
After adding more logging in #89912 I've been trying to figure out what happens here and it looks like somehow the connection is closed before the stats collector handler is called, in that case the SDK retries an extra time. See the logs:
I'm not entirely sure what's causing this, any exception thrown within the test handlers should log an error and that's not happening here, therefore something is messing around with the connection. |
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
If sending request fails locally without reaching the server, the retryable exception is logged differently. This PR enables the logging for this scenario. Relates: elastic#88841 Relates: elastic#101608
I spent some time looking into this CI failure from 6 month ago. The symptom is as what @fcofdez described above. There was a retrying for PUT straight after the original send without a error response in between, i.e.:
Note the 1st retry follows the original send immediately while all other retries have a In this case, the error is logged with the |
If sending request fails locally without reaching the server, the retryable exception is logged differently. This PR enables the logging for this scenario. Relates: elastic#88841 Relates: elastic#101608 (cherry picked from commit 5204902) # Conflicts: # modules/repository-s3/src/internalClusterTest/java/org/elasticsearch/repositories/s3/S3BlobStoreRepositoryTests.java
If sending request fails locally without reaching the server, the retryable exception is logged differently. This PR enables the logging for this scenario. Relates: #88841 Relates: #101608 (cherry picked from commit 5204902) # Conflicts: # modules/repository-s3/src/internalClusterTest/java/org/elasticsearch/repositories/s3/S3BlobStoreRepositoryTests.java
If sending request fails locally without reaching the server, the retryable exception is logged differently. This PR enables the logging for this scenario. Relates: elastic#88841 Relates: elastic#101608
If sending request fails locally without reaching the server, the retryable exception is logged differently. This PR enables the logging for this scenario. Relates: elastic#88841 Relates: elastic#101608
If sending request fails locally without reaching the server, the retryable exception is logged differently. This PR enables the logging for this scenario. Relates: elastic#88841 Relates: elastic#101608
Since last update (2 months ago), there has no any meaningful CI failures. The 3 failures are unrelated:
|
Still no new failure. Just keep waiting. |
With the AWS SDK now upgraded to v2 in #126843 I believe this test failure is now either gone or, at the very least, changed beyond all recognition, so I'm closing it. |
Build scan:
https://gradle-enterprise.elastic.co/s/mkusffe2imt3i/tests/:plugins:repository-s3:internalClusterTest/org.elasticsearch.repositories.s3.S3BlobStoreRepositoryTests/testRequestStats
Reproduction line:
./gradlew ':plugins:repository-s3:internalClusterTest' --tests "org.elasticsearch.repositories.s3.S3BlobStoreRepositoryTests.testRequestStats" -Dtests.seed=E93397D14D4A1FEE -Dtests.locale=de-DE -Dtests.timezone=Asia/Chongqing -Druntime.java=17 -Dtests.fips.enabled=true
Applicable branches:
7.17
Reproduces locally?:
Didn't try
Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.repositories.s3.S3BlobStoreRepositoryTests&tests.test=testRequestStats
Failure excerpt:
The text was updated successfully, but these errors were encountered: