-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[ci] Retry installing gradle/wrapper up to 5 times #105787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/es-delivery (Team:Delivery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although, one question is how often are our CI builds actually downloading the wrapper? It should already be cached on CI agents. Does this only happen occasionally, like when we bump the wrapper version or do we consistently see that builds are having to download the wrapper?
@elasticmachine merge upstream |
@mark-vieira I somehow didn't realize, but the original complaint was actually for the lucene builds (I've added this there). I believe we should only download it between bumps and next image build. Still seems worth adding here since it's already done? |
Sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there by now any more gradle invocations?
just checked, still looks good |
Gradle wrapper does not have a built-in mechanism to retry downloads/installs, and downloads timeout fairly frequently.
Calling
./gradlew --version
will causegradlew
to install everything without doing any other real work. Let's use that in a retry loop.Adding this retry mechanism to these two scripts should cover almost all of CI.