Break on FieldData when building global ordinals #108875
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @iverase, I've created a changelog YAML for you. |
|
I think this is the right thing to do, but:
|
… into globalOrdinalBreak
|
This seems like the safe thing to do. Why wouldn't we want to check the CB on ordinal creation to protect users? |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@iverase Did we want to pursue this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when building global ordinals, we add to the breaker the size of the final object without breaking. I think the reason for not breaking is that it makes little sense to break at that point if we already build the object. The side effect is that we don't honour the breaker limit which is equally bad.
Therefore this commit proposes to add the bytes and break if we get over the limit of the breaker. the side effect is that working cluster might be hitting this breaker now. Still not honouring a limit should be considered a bug.
closes #97075