SQL: make date format functions more strict #112140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
commented
Aug 23, 2024
| .build(), | ||
| new Builder().pattern("%u").javaFormat(t -> String.format(Locale.ROOT, "%02d", t.get(WeekFields.ISO.weekOfYear()))).build(), | ||
| new Builder().pattern("%u") | ||
| .javaFormat(t -> String.format(Locale.ENGLISH, "%02d", t.get(WeekFields.of(DayOfWeek.MONDAY, 4).weekOfYear()))) |
There was a problem hiding this comment.
This is exactly how MySQL spec defines %u
luigidellaquila
commented
Aug 23, 2024
| .javaFormat(t -> String.format(Locale.ENGLISH, "%02d", t.get(WeekFields.of(DayOfWeek.SUNDAY, 7).weekOfWeekBasedYear()))) | ||
| .build(), | ||
| new Builder().pattern("%v") | ||
| .javaFormat(t -> String.format(Locale.ENGLISH, "%02d", t.get(WeekFields.of(DayOfWeek.MONDAY, 4).weekOfWeekBasedYear()))) |
There was a problem hiding this comment.
This is exactly how MySQL spec defines %v
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Wait for #112196 before merging |
|
@elasticmachine update branch |
|
@luigidellaquila Is it ok to backport this to 8.15 and 7.17? |
|
@thecoop For 8.15 I don't see any problems. |
|
I can take care of it tomorrow |
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
thecoop
pushed a commit
to thecoop/elasticsearch
that referenced
this pull request
Sep 5, 2024
thecoop
added a commit
that referenced
this pull request
Sep 5, 2024
Backport #112140 to 8.15 Co-authored-by: Luigi Dell'Aquila <[email protected]>
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Sep 5, 2024
luigidellaquila
added a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to
CLDRlocale provider (see #110222) exposed some problems related to date conversion functions.In particular, these functions are defined to mimic MySQL and PostgreSQL behavior, and tests that compare results with the corresponding queries in MySQL and PostgreSQL show a slightly different behavior with CLDR, eg.
Moninstead ofMondaywith the ROOT locale;This change makes the calculation more strict by
The problem is not present with COMPAT locale provider, the intention of this change is to fix failures introduced by #110222, but I'm doing this as a separate PR to make sure that the new implementation is also good with COMPAT and we are not introducing regressions (ie. that it works fine with both
COMPATandCLDR)