Use single-task queues in ReservedClusterStateService #118351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
commented
Dec 10, 2024
| "reserved cluster state [" + namespace + "]", | ||
| new ReservedStateUpdateTask( | ||
| namespace, | ||
| reservedStateChunk, | ||
| versionCheck, | ||
| handlers, | ||
| orderedHandlers, | ||
| ReservedClusterStateService.this::updateErrorState, | ||
| this::updateErrorState, |
There was a problem hiding this comment.
Huh, IntelliJ did this automatically.
prdoyle
commented
Dec 10, 2024
server/src/main/java/org/elasticsearch/reservedstate/service/ReservedClusterStateService.java
Outdated
Show resolved
Hide resolved
DaveCTurner
reviewed
Dec 10, 2024
prdoyle
force-pushed
the
file-watch-single-task-queues
branch
from
de382f8 to
4b1dacb
Compare
prdoyle
force-pushed
the
file-watch-single-task-queues
branch
from
4b1dacb to
aa9dfd6
Compare
|
Sorry for the force-push. I had a lot of messing around and wanted to leave the result in a reviewable state. This branch is now based on three main commits:
If you want to review commit-by-commit, it should be readable now. |
DaveCTurner
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tasks don't support batching, so submit each in its own queue.