Skip to content

[8.x] Lazily initialize TransportActionStats in RequestHandlerRegistry (#117435) #118381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 8.19
Choose a base branch
from
Open

[8.x] Lazily initialize TransportActionStats in RequestHandlerRegistry (#117435) #118381

wants to merge 1 commit into from

Conversation

original-brownbear
Copy link
Member

Backports the following commits to 8.x:

@original-brownbear
Lazily initialize TransportActionStats in RequestHandlerRegistry (ela…
6e2c7a3 
…stic#117435)

Same as elastic#114107 but for the transport side. We are consuming more than
0.5M for these stat instances and a large fraction if not the majority
will go unused in many use-cases, given how expensive stats are in terms
of volatile operations the overhead of an added `getAcquire` is trivial
in the absence of writes. Outside of reducing the prod footprint this is
also kind of nice in x-pack internal cluster tests in particular where
it saves quite a bit of heap.
@original-brownbear original-brownbear added :Core/Infra/Metrics Metrics and metering infrastructure :Data Management/Stats Statistics tracking and retrieval APIs >non-issue auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Core/Infra Meta label for core/infra team Team:Data Management Meta label for data/management team labels Dec 10, 2024
@elasticsearchmachine elasticsearchmachine mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Core/Infra/Metrics Metrics and metering infrastructure :Data Management/Stats Statistics tracking and retrieval APIs >non-issue Team:Core/Infra Meta label for core/infra team Team:Data Management Meta label for data/management team v8.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@original-brownbear @elasticsearchmachine