Speedup Injector during concurrent node starts #118588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets simplify this logic a little and lock on the injector instance instead of the class. Locking on the class acutally wastes lots of time during test runs it turns out, especially with multi-cluster tests.
original-brownbear
added
>non-issue
:Core/Infra/Node Lifecycle
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
original-brownbear
added
auto-backport
|
Thanks Ryan! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Dec 12, 2024
Lets simplify this logic a little and lock on the injector instance instead of the class. Locking on the class actually wastes lots of time during test runs it turns out, especially with multi-cluster tests.
💚 Backport successful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change to up test performance a little more that I found over the weekend when debugging tests and running the profiler for fun and profit :)
Let's simplify this logic a little to make it clear that we only have two cases for the scope at compile time and lock on the injector instance instead of the class by inlining the scoping logic.
Locking on the class actually wastes lots of time during test runs (O(10s) during x-pack as well as server internal cluster tests) it turns out (especially when running multi-cluster (CCR/CCS) tests, or starting many nodes).