Skip to content

[8.x] Adding support for binary embedding type to Cohere service embedding type (#120751) #121584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Feb 3, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…type (elastic#120751)

* Adding support for binary embedding type to Cohere service embedding type

* Returning response in separate text_embedding_bits field

* Update x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/InferenceByteEmbedding.java

Co-authored-by: David Kyle <[email protected]>

* Update docs/changelog/120751.yaml

* Reverting docs change

---------

Co-authored-by: David Kyle <[email protected]>
(cherry picked from commit 89d71e1)

# Conflicts:
#	server/src/main/java/org/elasticsearch/TransportVersions.java
#	x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/InferenceTextEmbeddingByteResults.java
@ymao1
Copy link
Contributor Author

ymao1 commented Feb 4, 2025

run elasticsearch-ci

@ymao1 ymao1 merged commit e20fded into elastic:8.x Feb 4, 2025
15 checks passed
@ymao1 ymao1 deleted the backport/8.x/pr-120751 branch February 4, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants