-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Index-time scripted fields to be fetched from doc values #122376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
javanna
wants to merge
11
commits into
elastic:main
Choose a base branch
from
javanna:fix/index_time_scripts_doc_value_fetcher
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Index-time scripted fields to be fetched from doc values #122376
javanna
wants to merge
11
commits into
elastic:main
from
javanna:fix/index_time_scripts_doc_value_fetcher
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreidan
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this Luca!
Extra props for the PR description and all the tests ❤️
LGTM from a code changes perspective - pending other approvals.
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Hi @javanna, I've created a changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
>bug
:Search Foundations/Search
Catch all for Search Foundations
Team:Search Foundations
Meta label for the Search Foundations team in Elasticsearch
test-full-bwc
Trigger full BWC version matrix tests
v8.16.7
v8.17.7
v8.18.2
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain field types support index-time scripts. When a script is provided for them, values for such fields are not accepted in incoming documents. Instead, the script is executed at index time and the result of the script is indexed. There is no trace of the resulting value in
_source
, but such calculated fields can be queried, aggregated on etc.The described calculated fields can also be retrieved as part of the fetch phase, using the fields API or docvalue_fields. The fetch fields api is though re-executing the script at fetch time as opposed to retrieving the value that is in the index. That causes discrepancy between indexing, querying and fetching. This PR addresses that by retrieving the value from doc values. There's a couple of limitations with this approach:
_source
like ordinarily ingested fieldsThese limitations are not great, but I think that fixing the bug of not re-running the script at fetch time is valuable. Re-executing the script at fetch is unexpected: users may have indexed such scripted fields for better performance for instance, and reexecuting the script may lead to a different result, depending on the content of the script.
Closes #119939