-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Improve exception handling for JsonXContentParser #123439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smalyshev
wants to merge
16
commits into
elastic:main
Choose a base branch
from
smalyshev:json-parser-exc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c9d4bb7
Improve exception handling for JsonXContentParser
smalyshev 99bca26
Merge branch 'main' into json-parser-exc
smalyshev 617f12a
Fix tests
smalyshev 2b3f32b
Merge branch 'main' into json-parser-exc
smalyshev d37e09c
More test fixes
smalyshev 20a0f9e
Wrap parser creation so that bad char sequences do not cause 500
smalyshev 428ec3c
Merge branch 'main' into json-parser-exc
smalyshev ca7b09e
Unroll safeParse due to performance concerns
smalyshev ddb4c98
Add parser-only microbenchmark
smalyshev 900da19
spotless
smalyshev c1ddf1a
Merge branch 'main' into json-parser-exc
smalyshev 82ad73f
Merge branch 'main' into json-parser-exc
smalyshev 0771670
Merge branch 'main' into json-parser-exc
smalyshev 9b1331b
Merge branch 'main' into json-parser-exc
smalyshev a53dd2b
Merge branch 'main' into json-parser-exc
smalyshev e33ea1e
Merge branch 'main' into json-parser-exc
smalyshev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Wrap parser creation so that bad char sequences do not cause 500
- Loading branch information
commit 20a0f9e85e3a83c6748ceecc7dbc4aa84d9f4dac
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JsonFactory.createParser can throw JsonParseException, so shouldn't this catch also use handleParseException?