Skip to content

add es code comments for testing #124283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

add es code comments for testing #124283

wants to merge 14 commits into from
+1,521 −82

Conversation

georgewallace
Copy link
Contributor

No description provided.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 labels Mar 7, 2025
@georgewallace georgewallace added >docs General docs changes Team:Docs Meta label for docs team labels Mar 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Mar 7, 2025
@leemthompo leemthompo mentioned this pull request Mar 13, 2025
Open
leemthompo
leemthompo approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go? Approving to unblock.

@brianseeders
Copy link
Contributor

Did you manually fix the problems from my comments? I figured someone would fix it in the code that generated the comments and then re-generate them. There are actually a lot more examples all over the place, especially of the escape characters getting dropped. Is it possible to fix the automation and regenerate?

Here are a few more issues I've found:

reference/data-analysis/aggregations/search-aggregations-bucket-geohashgrid-aggregation.md:194 - There should be a NOTCONSOLE comment that got dropped for some reason.

reference/elasticsearch/rest-apis/sort-search-results.md - The first test is marked with TEST[continued], which doesn't make sense. I'm guessing it got moved from somewhere else? There are more examples of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianseeders brianseeders brianseeders left review comments

@szabosteve szabosteve szabosteve left review comments

@leemthompo leemthompo leemthompo approved these changes

Assignees
No one assigned
Labels
>docs General docs changes Team:Docs Meta label for docs team v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@georgewallace @elasticsearchmachine @brianseeders @szabosteve @leemthompo @colleenmcginnis