Reduce use of deprecated Metadata builder method #124290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes all non-test usage of
Metadata.Builder.put(IndexMetadata.Builder)
And replaces it with appropriate calls to the equivalent method on
`ProjectMetadata.Builder`
In most cases this _does not_ make the code project aware, but does
reduce the number of deprecated methods in use
tvernum
added
:Distributed Indexing/CRUD
elasticsearchmachine
added
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
ywangd
approved these changes
Mar 12, 2025
| @@ -287,6 +289,8 @@ static ClusterState unfollow(String followerIndex, ClusterState current) { | |||
| // Remove ccr custom metadata | |||
| newIndexMetadata.removeCustom(Ccr.CCR_CUSTOM_METADATA_KEY); | |||
|
|
|||
| return current.copyAndUpdateMetadata(metadata -> metadata.put(newIndexMetadata)); | |||
| @FixForMultiProject | |||
| final ProjectId projectId = current.metadata().getProject().id(); | |||
x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/IndexLifecycleTransition.java
Outdated
Show resolved
Hide resolved
tvernum
deleted the
multi-project/metadata-builder/put-index-metadata-builder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all non-test usage of
And replaces it with appropriate calls to the equivalent method on
ProjectMetadata.BuilderIn most cases this does not make the code project aware, but does reduce the number of deprecated methods in use