Skip to content

Refactor CrossClusterQueryWithPartialResultsIT tests #124811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 14, 2025
Merged

Refactor CrossClusterQueryWithPartialResultsIT tests #124811

merged 4 commits into from
Mar 14, 2025

Conversation

smalyshev
Copy link
Contributor

@smalyshev smalyshev commented Mar 13, 2025 •
edited
Loading

  1. Execution info is available regardless of includeCCSMetadata so check should always be happening.
  2. We use the same ways to check successful and partial clusters - use common method to check them to avoid copypaste errors and make code cleaner.

See: #122708

@smalyshev smalyshev added :Analytics/ES|QL AKA ESQL :Search Foundations/CCS >test Issues or PRs that are addressing/adding tests >refactoring v9.1.0 v8.19.0 auto-backport Automatically create backport pull requests when merged labels Mar 13, 2025
@smalyshev smalyshev requested a review from dnhatn March 13, 2025 20:26
@smalyshev smalyshev marked this pull request as ready for review March 13, 2025 20:26
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels Mar 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

dnhatn
dnhatn approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smalyshev

@smalyshev smalyshev enabled auto-merge (squash) March 13, 2025 20:44
@smalyshev smalyshev merged commit 35cdc82 into elastic:main Mar 14, 2025
17 checks passed
@smalyshev smalyshev mentioned this pull request Mar 14, 2025
Merged
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Mar 14, 2025
@smalyshev
Refactor CrossClusterQueryWithPartialResultsIT tests (elastic#124811)
21710e7
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.x

elasticsearchmachine pushed a commit that referenced this pull request Mar 14, 2025
@smalyshev
Refactor CrossClusterQueryWithPartialResultsIT tests (#124811) (#124842)
4951289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnhatn dnhatn dnhatn approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >refactoring :Search Foundations/CCS Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smalyshev @elasticsearchmachine @dnhatn