Include failures in partial response #124929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
return-partial-failures
branch
2 times, most recently
from
b71ca6b to
7536a7f
Compare
dnhatn
force-pushed
the
return-partial-failures
branch
from
7536a7f to
6fd6697
Compare
dnhatn
force-pushed
the
return-partial-failures
branch
from
6fd6697 to
b164f25
Compare
|
Hi @dnhatn, I've created a changelog YAML for you. |
dnhatn
added
the
auto-backport
10 tasks
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
This reverts commit 1e3dba2.
smalyshev
approved these changes
Mar 16, 2025
|
Thanks @smalyshev. |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Mar 17, 2025
This change includes failures when ESQL returns partial results. It also carries failures between cluster requests. Relates elastic#122802
dnhatn
added a commit
that referenced
this pull request
Mar 17, 2025
This change includes failures when ESQL returns partial results. It also carries failures between cluster requests. Relates #122802
| final Set<Exception> seen = Collections.newSetFromMap(new IdentityHashMap<>()); | ||
| for (Map.Entry<ShardId, ShardFailure> e : shardFailures.entrySet()) { | ||
| final ShardFailure failure = e.getValue(); | ||
| if (ExceptionsHelper.unwrap(failure.failure(), TaskCancelledException.class) != null) { |
There was a problem hiding this comment.
I wonder if it is worth keeping unwrapped exception in trackShardLevelFailure?
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Mar 17, 2025
* main: (95 commits) Mute org.elasticsearch.datastreams.lifecycle.DataStreamLifecycleServiceIT testLifecycleAppliedToFailureStore elastic#124999 Merge template mappings properly during validation (elastic#124784) [Build] Rework internal build plugin plugin to work with Isolated Projects (elastic#123461) [Build] Require reason for usesDefaultDistribution (elastic#124707) Mute org.elasticsearch.packaging.test.DockerTests test011SecurityEnabledStatus elastic#124990 Mute org.elasticsearch.xpack.ilm.TimeSeriesDataStreamsIT testRolloverAction elastic#124987 Mute org.elasticsearch.packaging.test.BootstrapCheckTests test10Install elastic#124957 Mute org.elasticsearch.integration.DataStreamLifecycleServiceRuntimeSecurityIT testRolloverLifecycleAndForceMergeAuthorized elastic#124978 Mute org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryStopIT testStopQuery elastic#124977 Mute org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryStopIT testStopQueryLocal elastic#121672 Mention zero-window state in networking docs (elastic#124967) Remove remoteAddress field from TransportResponse (elastic#120016) Include failures in partial response (elastic#124929) Prevent work starvation bug if using scaling EsThreadPoolExecutor with core pool size = 0 (elastic#124732) Re-enable analysis stemmer test (elastic#124961) Mute org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryStopIT testStopQueryLocalNoRemotes elastic#124959 ESQL: Catch parsing exception (elastic#124958) ESQL: Improve error message for ( and [ (elastic#124177) Mute org.elasticsearch.xpack.esql.qa.single_node.EsqlSpecIT test {lookup-join.MvJoinKeyFromRow SYNC} elastic#124951 Mute org.elasticsearch.datastreams.lifecycle.DataStreamLifecycleServiceIT testErrorRecordingOnRetention elastic#124950 ... # Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java # server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldTypeTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 20, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Mar 21, 2025
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
|
Why was this backported to 8.x and not 9.0? |
@mark-vieira Two reasons why we didn’t backport this to 9.0: (1) it requires wire-compact, and (2) this enhancement has no impact on 9.0, where we don't support partial results. |
Gotcha, is that common to skip branches like this? I hit this when doing some backports and found it awkward that there was a "gap" here. |
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
This change includes failures when ESQL returns partial results. It also carries failures between cluster requests. Relates elastic#122802
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes failures when ESQL returns partial results. It also carries failures between cluster requests.
Relates #122802