Fix failing docker packaging tests due to too long commandline #125053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
added
:Delivery/Packaging
There was a problem hiding this comment.
Pull Request Overview
This PR addresses failing docker packaging tests by replacing the usage of "ps ax" with a direct call to "jps" to avoid issues with overly long command lines.
- Changed the shell command to use "/usr/share/elasticsearch/jdk/bin/jps -mlV" for better output.
Comments suppressed due to low confidence (1)
qa/packaging/src/test/java/org/elasticsearch/packaging/util/docker/Docker.java:190
- Ensure that the specified jps binary exists in all expected docker environments; consider adding a fallback or check to prevent potential runtime errors if the binary is missing.
psOutput = dockerShell.run("bash -c '/usr/share/elasticsearch/jdk/bin/jps -mlV'").stdout();
7c2a5cd to
22dda80
Compare
breskeby
force-pushed
the
fix-packaging-tests
branch
from
22dda80 to
768db15
Compare
💔 Backport failed
You can use sqren/backport to manually backport by running |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 20, 2025
…ic#125053) * Increate COLUMN for detecting running elasticsearch instance * Unmute DockerTest test (cherry picked from commit 38f2439) # Conflicts: # muted-tests.yml
This was referenced Mar 20, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 20, 2025
…ic#125053) * Increate COLUMN for detecting running elasticsearch instance * Unmute DockerTest test (cherry picked from commit 38f2439) # Conflicts: # muted-tests.yml
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 20, 2025
…ic#125053) * Increate COLUMN for detecting running elasticsearch instance * Unmute DockerTest test (cherry picked from commit 38f2439) # Conflicts: # muted-tests.yml
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 20, 2025
…ic#125053) * Increate COLUMN for detecting running elasticsearch instance * Unmute DockerTest test (cherry picked from commit 38f2439) # Conflicts: # muted-tests.yml # qa/packaging/src/test/java/org/elasticsearch/packaging/util/docker/Docker.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
breskeby
added a commit
that referenced
this pull request
Mar 21, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Mar 21, 2025
…ic#125053) * Increate COLUMN for detecting running elasticsearch instance * Unmute DockerTest test
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
…ic#125053) * Increate COLUMN for detecting running elasticsearch instance * Unmute DockerTest test
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…ic#125053) * Increate COLUMN for detecting running elasticsearch instance * Unmute DockerTest test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use jps for now to avoid issues with too long commandline when relying on plain ps ax and terminal specific COLUMN restrictions.
Fixes #119441