[ML] Delay copying chunked input strings #125837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
approved these changes
Mar 28, 2025
davidkyle
added
the
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Apr 7, 2025
The chunked text is only required when the actual inference request is made, using a string supplier means the string creation can be done much much closer to where the request is made reducing the lifespan of the copied string. (cherry picked from commit c521264) # Conflicts: # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/chunking/EmbeddingRequestChunkerTests.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 7, 2025
The chunked text is only required when the actual inference request is made, using a string supplier means the string creation can be done much much closer to where the request is made reducing the lifespan of the copied string. (cherry picked from commit c521264) # Conflicts: # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/chunking/EmbeddingRequestChunkerTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chunker stores the position of each chunk's text in the original text rather than making copies. However, when an inference request is made the actual chunk text is required, at this point a copy must be made. The copying is done when
String#subString()is called.The PR reduces the lifetime of the string copies but returning a string Supplier in from the chunker and performing the copy closer to where the request will be made. See
RequestExecutorServiceelasticsearch/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/http/sender/RequestExecutorService.java
Line 466 in a40370a
As a follow up once #125567 is merged
EmbeddingInputswill be moved toRequest#createHttpRequest()so that the string copy will be made at the point the http request is constructed further reducing the lifespan of the copy.I had to change the logic around
InferenceInput#inputSize()to avoid calling the supplier function early of find out if there was more than 1 input.