Add support for a custom transport version check predicate in ElasticsearchException #126272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Apr 4, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Apr 9, 2025
…searchException (elastic#126272) Today when we are adding a ElasticsearchException, we specify a versionAdded TransportVersion (the transport version from which we support it); this version is checked by the isRegistered method: return version.onOrAfter(elasticsearchExceptionHandle.versionAdded); This does not play well with backports; when we add a patch version for a backport, normally the procedure would be to change the code above take also the patch into account, like: version.orOnAfter(versionAdded) || version.isPatchFrom(versionPatched) This PR updates ElasticsearchException to have more than just "version added", so that we can do patches as described above.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 9, 2025
…searchException (#126272) (#126520) Today when we are adding a ElasticsearchException, we specify a versionAdded TransportVersion (the transport version from which we support it); this version is checked by the isRegistered method: return version.onOrAfter(elasticsearchExceptionHandle.versionAdded); This does not play well with backports; when we add a patch version for a backport, normally the procedure would be to change the code above take also the patch into account, like: version.orOnAfter(versionAdded) || version.isPatchFrom(versionPatched) This PR updates ElasticsearchException to have more than just "version added", so that we can do patches as described above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when we are adding a ElasticsearchException, we specify a
versionAddedTransportVersion (the transport version from which we support it); this version is checked by theisRegisteredmethod:This does not play well with backports; when we add a patch version for a backport, normally the procedure would be to change the code above take also the patch into account, like:
This PR updates ElasticsearchException to have more than just "version added", so that we can do patches as described above.