-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Add Issuer to failed SAML Signature validation logs when available #126310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
richard-dennehy
merged 15 commits into
elastic:main
from
richard-dennehy:saml-issuer-in-warn-logs
Apr 8, 2025
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
39fe357
Add Issuer to failed SAML Signature validation logs when available
richard-dennehy 8d4d813
[CI] Auto commit changes from spotless
elasticsearchmachine 8533c8e
Fix tests
richard-dennehy f714d35
Update docs/changelog/126310.yaml
richard-dennehy 312b2ab
Merge branch 'main' of github.com:elastic/elasticsearch into saml-iss…
richard-dennehy 198cdf9
address review comments
richard-dennehy 7de3149
replace String.format call
richard-dennehy f5ff8b1
update formatIssuer to describeIssuer
richard-dennehy 301f6a0
[CI] Auto commit changes from spotless
elasticsearchmachine fa9b48c
truncate long issuers in log messages
richard-dennehy 16cb4b8
[CI] Auto commit changes from spotless
elasticsearchmachine de44463
handle null issuer value
richard-dennehy 42ebafc
address review comments
richard-dennehy 474a79c
Merge branch 'main' into saml-issuer-in-warn-logs
richard-dennehy 4893144
Merge branch 'main' into saml-issuer-in-warn-logs
richard-dennehy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
update formatIssuer to describeIssuer
- Loading branch information
commit f5ff8b17db4f2938233cfa42b9e715ba4cc44457
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove duplication (since I need to edit the exact same log message twice)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!