-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Revive read/write engine lock to guard operations against resets #126311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d290507
Revert "Revert "Use read/write engine lock to guard operations agains…
tlrx 87e403f
add EngineReadWriteLock
tlrx 6e4a5de
acquire read lock before refresh
tlrx 1085560
Use lock for resets only
tlrx d8760e3
Add test for deadlock
tlrx a9832eb
sometimes
tlrx 05ebd5c
doc about non-blocking refreshes and reset
tlrx eb83fdb
assertNoEngineResetLock
tlrx 2b9de63
readLock and comment
tlrx 6323e32
move EngineResetLock
tlrx e79c19a
[CI] Auto commit changes from spotless
elasticsearchmachine 24796c2
== false
tlrx ea5768d
remove more readlocks
tlrx 22f846d
remove some assertNoEngineResetLock
tlrx 07a8558
also read lock on flushes
tlrx 94517c7
feedback
tlrx 4901c6a
[CI] Auto commit changes from spotless
elasticsearchmachine 19683eb
assert
tlrx b97d93a
Merge branch 'main' into ES-10826-the-return
tlrx 64bcd92
Merge branch 'main' into ES-10826-the-return
tlrx 1f24aaf
Merge branch 'main' into ES-10826-the-return
tlrx 5fa911f
Merge branch 'main' into ES-10826-the-return
tlrx 2411a9b
onSettingsChanged
tlrx 93c25da
sameInstance
tlrx 404e104
Merge branch 'main' into ES-10826-the-return
tlrx 4cf4146
Revert "onSettingsChanged"
tlrx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
acquire read lock before refresh
- Loading branch information
commit 6e4a5decfa2c5b812c753a6fe7de18f84afe33a3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a6cad19