-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[ES|QL] COMPLETION command grammar and logical plan #126319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] COMPLETION command grammar and logical plan #126319
Conversation
…esql-completion-logical-plan
Hi @afoucret, I've created a changelog YAML for you. |
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/LogicalPlanBuilder.java
Outdated
Show resolved
Hide resolved
...lugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/inference/Completion.java
Outdated
Show resolved
Hide resolved
...lugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/inference/Completion.java
Show resolved
Hide resolved
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/LogicalPlanBuilder.java
Outdated
Show resolved
Hide resolved
Pinging @elastic/es-analytical-engine (Team:Analytics) |
…esql-completion-logical-plan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with getting this PR in first and allow for incremental progress.
It's snapshot only so we should be good.
Looking at the current changes I don't think they will change dramatically when you end up implementing the rest of the COMPLETION command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...esql/src/test/java/org/elasticsearch/xpack/esql/parser/GrammarInDevelopmentParsingTests.java
Outdated
Show resolved
Hide resolved
…parser/GrammarInDevelopmentParsingTests.java Co-authored-by: Carlos Delgado <[email protected]>
This PR implement the grammar and logical plan for the
COMPLETION
command:prompt
: expression for the prompt to be send to the LLM, requiredinferenceId
: the inference id for the inference endpoint to be used, requiredtargetField
: name of he output target field, optional default =completion
Work for the completion command is tracked in: #124405.