Skip to content

[ES|QL] COMPLETION command grammar and logical plan #126319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 11, 2025

Conversation

afoucret
Copy link
Contributor

@afoucret afoucret commented Apr 4, 2025

This PR implement the grammar and logical plan for the COMPLETION command:

| COMPLETION <prompt> WITH <inferenceId> AS <targertField>
  • prompt: expression for the prompt to be send to the LLM, required
  • inferenceId: the inference id for the inference endpoint to be used, required
  • targetField: name of he output target field, optional default = completion

Work for the completion command is tracked in: #124405.

@elasticsearchmachine
Copy link
Collaborator

Hi @afoucret, I've created a changelog YAML for you.

@afoucret afoucret marked this pull request as ready for review April 10, 2025 08:57
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@afoucret afoucret mentioned this pull request Mar 26, 2025
9 tasks
Copy link
Contributor

@ioanatia ioanatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with getting this PR in first and allow for incremental progress.
It's snapshot only so we should be good.
Looking at the current changes I don't think they will change dramatically when you end up implementing the rest of the COMPLETION command.

@afoucret afoucret added the test-release Trigger CI checks against release build label Apr 10, 2025
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@afoucret afoucret removed the test-release Trigger CI checks against release build label Apr 10, 2025
@afoucret afoucret merged commit 6842203 into elastic:main Apr 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >feature Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants