-
Notifications
You must be signed in to change notification settings - Fork 25.2k
ES-10037 Tweak wording of autosharding logs #126339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES-10037 Tweak wording of autosharding logs #126339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I do think that is clearer, thanks for doing this. I also left a super-minor optional comment.
"For data stream %s: %s based on [inc/dec cooldowns %s/%s, %d-%d threads, " | ||
+ "write index %s has all-time/recent/peak loads %g/%g/%g, current shards %d, " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super minor, so I leave it up to you whether you think it clarifies or not. Feel free to disregard my pedantry :)
When I think of /
I think of it as alternative meanings for something (e.g., "my mother/care-taker" being verbalized as "my mother-slash-care-taker"). What do you think of something like:
"For data stream %s: %s based on [inc/dec cooldowns %s/%s, %d-%d threads, " | |
+ "write index %s has all-time/recent/peak loads %g/%g/%g, current shards %d, " | |
"For data stream %s: %s based on [inc/dec cooldowns %s/%s, %d-%d threads, " | |
+ "write index %s has [all-time|recent|peak] loads [%g|%g|%g], current shards %d, " |
To clarify that they are corresponding values, instead of potentially implying that the loads are conflated and perhaps mixed?
(I realize the irony of replacing the /
with |
since |
already connotes an "or" meaning, hence why this is so minor and up to you whether to make any changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See, I'm not sure that I'd find your version more clear!
I don't think that /
is only used for alternative meanings. It's also used in dates, for example. If I said that a broadband speed test had a result of 800/500 Mbps for download/upload, would that be confusing?
I think I'm going to respectfully suggest that we've spent enough time on this, we appear to have reached a point where there's a subjective difference on the clearest punctuation without a clear answer, and I'm just going to mash the merge button...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's totally reasonable! No worries at all, that's part of why I tried to couch it in optional language 😄
Pinging @elastic/es-data-management (Team:Data Management) |
No description provided.