Restrict failure stores from replicating via CCR #126355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiera
added
>non-issue
:Distributed Indexing/CCR
elasticsearchmachine
added
v9.1.0
Team:Data Management
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
@elasticmachine update branch |
arteam
approved these changes
Apr 9, 2025
jbaiera
added
auto-backport
💚 Backport successful
|
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Apr 9, 2025
Checks to see if an index belongs to a data stream's failure store before following it. If the index is a failure index, the follow operation is rejected. Also updates the logic in the auto follower API's to exclude failure indices on data streams from being followed if their parent data stream matches the follow pattern.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 9, 2025
Checks to see if an index belongs to a data stream's failure store before following it. If the index is a failure index, the follow operation is rejected. Also updates the logic in the auto follower API's to exclude failure indices on data streams from being followed if their parent data stream matches the follow pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks to see if an index belongs to a data stream's failure store before following it. If the index is a failure index, the follow operation is rejected. Also updates the logic in the auto follower API's to exclude failure indices on data streams from being followed if their parent data stream matches the follow pattern.
The auto follow test for data stream replication has been updated to operate on a data stream that has failure indices on it to ensure they are not replicated. The CCRLicenseChecker (where a surprising amount of validation for the put follow API takes place) has been updated to throw an exception when a failure store index is encountered.
Without this in place, when replicating a data stream with auto follow, the remote data stream's failure store indices are replicated to the local cluster and added to the data stream's backing index set instead of to its own failure store set. We have additional work/thinking that needs to be done before we can fix this and replicate them correctly. See #126356.