Shard level search stats - DfsPhase #126380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com:drempapis/elasticsearch into ShardSearchStats_usage_search_load_per_index
drempapis
added
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
…ub.com:drempapis/elasticsearch into ShardSearchStats_usage_search_load_per_index
benchaplin
reviewed
Apr 9, 2025
| @@ -113,6 +134,13 @@ private Stats(StreamInput in) throws IOException { | |||
|
|
|||
| @Override | |||
| public void writeTo(StreamOutput out) throws IOException { | |||
| if (out.getTransportVersion().onOrAfter(TransportVersions.DFS_STATS)) { | |||
There was a problem hiding this comment.
Out of curiosity - do we ever clean up these checks once we're far enough into the future to safely assume all nodes are upgraded past this version?
There was a problem hiding this comment.
Thank you, Ben, for the review. Yes, there is a cleanup process; please check the following pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances metrics collection by tracking time metrics and failures executions of
DFS(Distributed Frequency Search). These metrics are exposed through the Stats API.The
SearchOperationListenerhas been extended to support DFS tracking, withShardSearchStatsproviding the underlying implementation.