-
Notifications
You must be signed in to change notification settings - Fork 25.2k
ESQL: Preserve single aggregate when all attributes are pruned #126397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fang-xing-esql
merged 16 commits into
elastic:main
from
kanoshiou:remove-empty-attribute-in-merging-output
Apr 21, 2025
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a68eb40
Remove empty attribute
kanoshiou 0171eb7
Update docs/changelog/126397.yaml
kanoshiou b5f15b3
Add csv tests
kanoshiou 7bbad91
Update LogicalPlanOptimizerTests
kanoshiou ce6fd7b
Fix bwc
kanoshiou 41f5c42
Merge branch 'main' into remove-empty-attribute-in-merging-output
kanoshiou e70ad94
Merge branch 'main' into remove-empty-attribute-in-merging-output
fang-xing-esql 1fc9811
Merge branch 'main' into remove-empty-attribute-in-merging-output
fang-xing-esql 8487022
Merge branch 'refs/heads/main' into remove-empty-attribute-in-merging…
kanoshiou e63dfc5
Avoid using `EmptyAttribute`
kanoshiou 64f54e3
Merge branch 'main' into remove-empty-attribute-in-merging-output
fang-xing-esql 01f8f15
Merge branch 'main' into remove-empty-attribute-in-merging-output
fang-xing-esql 717f0a2
[CI] Auto commit changes from spotless
elasticsearchmachine 18281f9
Merge branch 'main' into remove-empty-attribute-in-merging-output
fang-xing-esql feb077e
Update docs/changelog/126397.yaml
kanoshiou 6733c76
Merge branch 'main' into remove-empty-attribute-in-merging-output
fang-xing-esql File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
pr: 126397 | ||
summary: "ESQL: Preserve single aggregate when all attributes are pruned" | ||
area: ES|QL | ||
type: bug | ||
issues: | ||
- 126392 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about something like
List.of(aggregate.output().get(0))
, your way does a similar job too.