Skip to content

Replace TransportResponse.Empty with ActionResponse.Empty #126400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DaveCTurner
Copy link
Contributor

No need to distinguish these things any more, we can just use
ActionResponse.Empty everywhere.

No need to distinguish these things any more, we can just use
`ActionResponse.Empty` everywhere.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Apr 7, 2025
@DaveCTurner DaveCTurner added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged and removed serverless-linked Added by automation, don't add manually labels Apr 7, 2025
@elasticsearchmachine elasticsearchmachine merged commit cedcb5c into elastic:main Apr 7, 2025
17 checks passed
@DaveCTurner DaveCTurner deleted the 2025/04/07/remove-TransportResponse-Empty branch April 7, 2025 20:58
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 126400

DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 7, 2025
No need to distinguish these things any more, we can just use
`ActionResponse.Empty` everywhere.

Backport of elastic#126400 to `8.x`
@DaveCTurner
Copy link
Contributor Author

Backport is #126432

elasticsearchmachine pushed a commit that referenced this pull request Apr 8, 2025
No need to distinguish these things any more, we can just use
`ActionResponse.Empty` everywhere.

Backport of #126400 to `8.x`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Transport API Transport client API >refactoring Team:Core/Infra Meta label for core/infra team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants