-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[main] System data streams are not being upgraded in the feature migration API #126409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] System data streams are not being upgraded in the feature migration API #126409
Conversation
…ation API This commit adds support for system data streams reindexing. The system data stream migration extends the existing system indices migration task and uses the data stream reindex API. The system index migration task starts a reindex data stream task and tracks its status every second. Only one system index or system data stream is migrated at a time. If a data stream migration fails, the entire system index migration task will also fail. Port of elastic#123926
…le migrated prefix (elastic#125598) There is a theoretical possibility of having an index backing a system data stream with a name starting with .migrated-migrated-. This currently results in an error when accessing the data stream. This commit fixes the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A few minor comments, not blocking.
docs/changelog/124884.yaml
Outdated
@@ -0,0 +1,6 @@ | |||
pr: 124884 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this reference the current PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
stateIndexName | ||
) | ||
) | ||
); | ||
} | ||
logger.warn( | ||
() -> format( | ||
"resuming system index migration with index [%s], which does not match index given in last task state [%s]", | ||
nextMigrationInfo.getCurrentIndexName(), | ||
"resuming system index migration with resource [%s]," |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: system index -> system resource?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
This commit adds support for system data streams reindexing. The system data stream migration extends the existing system indices migration task and uses the data stream reindex API.
The system index migration task starts a reindex data stream task and tracks its status every second. Only one system index or system data stream is migrated at a time. If a data stream migration fails, the entire system index migration task will also fail.
Port of #123926
This PR also includes port of #125598