Skip to content

[main] System data streams are not being upgraded in the feature migration API #126409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexey-ivanov-es
Copy link
Contributor

@alexey-ivanov-es alexey-ivanov-es commented Apr 7, 2025

This commit adds support for system data streams reindexing. The system data stream migration extends the existing system indices migration task and uses the data stream reindex API.
The system index migration task starts a reindex data stream task and tracks its status every second. Only one system index or system data stream is migrated at a time. If a data stream migration fails, the entire system index migration task will also fail.

Port of #123926

This PR also includes port of #125598

…ation API

This commit adds support for system data streams reindexing. The system data stream migration extends the existing system indices migration task and uses the data stream reindex API.
The system index migration task starts a reindex data stream task and tracks its status every second. Only one system index or system data stream is migrated at a time. If a data stream migration fails, the entire system index migration task will also fail.

Port of elastic#123926
@alexey-ivanov-es alexey-ivanov-es added >bug :Core/Infra/Core Core issues without another label backport v9.1.0 labels Apr 7, 2025
@alexey-ivanov-es alexey-ivanov-es requested a review from a team as a code owner April 7, 2025 14:41
Copy link
Contributor

@JVerwolf JVerwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few minor comments, not blocking.

@@ -0,0 +1,6 @@
pr: 124884
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this reference the current PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

stateIndexName
)
)
);
}
logger.warn(
() -> format(
"resuming system index migration with index [%s], which does not match index given in last task state [%s]",
nextMigrationInfo.getCurrentIndexName(),
"resuming system index migration with resource [%s],"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: system index -> system resource?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@alexey-ivanov-es alexey-ivanov-es enabled auto-merge (squash) April 8, 2025 17:36
@alexey-ivanov-es alexey-ivanov-es merged commit ecf9adf into elastic:main Apr 8, 2025
17 checks passed
@alexey-ivanov-es alexey-ivanov-es deleted the system-data-streams-migration_main branch April 9, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport >bug :Core/Infra/Core Core issues without another label v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants