Correctly handle nulls in nested paths in the remove processor #126417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we run into a null, just treat that the same as any other missing field -- so if ignoreMissing is true, then we should not throw an exception.
joegallo
added
>bug
:Data Management/Ingest Node
joegallo
added
the
auto-backport
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @joegallo, I've created a changelog YAML for you. |
modules/ingest-common/src/test/java/org/elasticsearch/ingest/common/RemoveProcessorTests.java
Outdated
Show resolved
Hide resolved
💔 Backport failed
You can use sqren/backport to manually backport by running |
This was referenced Apr 7, 2025
This was referenced Apr 7, 2025
elasticsearchmachine
added a commit
that referenced
this pull request
Apr 8, 2025
…126463) * Correctly handle nulls in nested paths in the remove processor (#126417) * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
This was referenced Apr 8, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that was introduced by #125232.
During path traversal, if we find a
null, then that doesn't necessarily mean we must throw an exception -- rather, we should only throw an exception onnullifignoreMissingis false.