Select time-series indices with TS command #126436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
:Analytics/ES|QL
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Apr 8, 2025
| // TODO: Maybe if no indices are returned, retry without index mode and provide a clearer error message. | ||
| var indexModeFilter = new TermQueryBuilder(IndexModeFieldMapper.NAME, IndexMode.TIME_SERIES.getName()); | ||
| if (requestFilter != null) { | ||
| requestFilter = new BoolQueryBuilder().filter(requestFilter).filter(indexModeFilter); |
There was a problem hiding this comment.
How fast is this? Do we need to worry about performance?
There was a problem hiding this comment.
There is an overhead with field-caps when using indexFilter, as we have to dispatch sub-requests for every copy instead of one copy per index without the filter. However, this overhead should be small, and we plan to work on minimizing the overhead for index filters that can be rewritten on the coordinators.
kkrik-es
approved these changes
Apr 8, 2025
|
@martijnvg @kkrik-es Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the TS command will target only time_series indexes.