Skip to content

[ML] Move Inference Service request and response classes into service package #126482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

davidkyle
Copy link
Member

The final PR in a series that consolidates all the classes for each inference service into a single package: org.elasticsearch.xpack.inference.services.${SERVICE_NAME}

This PR moves the request and response classes from

org.elasticsearch.xpack.inference.external.request.alibabacloudsearch.${SERVICE_NAME}
org.elasticsearch.xpack.inference.external.response.alibabacloudsearch.${SERVICE_NAME}

to

org.elasticsearch.xpack.inference.services.${SERVICE_NAME}.request
org.elasticsearch.xpack.inference.services.${SERVICE_NAME}.response

Completes the changes started in #126114, #125928 and #125567

@davidkyle davidkyle added >refactoring :ml Machine learning auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels Apr 8, 2025
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Apr 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@davidkyle davidkyle enabled auto-merge (squash) April 8, 2025 16:10
@davidkyle davidkyle merged commit d2be03c into elastic:main Apr 8, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 126482

@davidkyle
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

davidkyle added a commit to davidkyle/elasticsearch that referenced this pull request Apr 10, 2025
… package (elastic#126482)

(cherry picked from commit d2be03c)

# Conflicts:
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceServiceSparseEmbeddingsRequestManager.java
#	x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/amazonbedrock/embeddings/AmazonBedrockCohereEmbeddingsRequestEntityTests.java
#	x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceServiceTests.java
#	x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/elastic/authorization/ElasticInferenceServiceAuthorizationHandlerTests.java
elasticsearchmachine pushed a commit that referenced this pull request Apr 10, 2025
… package (#126482) (#126590)

(cherry picked from commit d2be03c)

# Conflicts:
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceServiceSparseEmbeddingsRequestManager.java
#	x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/amazonbedrock/embeddings/AmazonBedrockCohereEmbeddingsRequestEntityTests.java
#	x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceServiceTests.java
#	x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/elastic/authorization/ElasticInferenceServiceAuthorizationHandlerTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending :ml Machine learning >refactoring Team:ML Meta label for the ML team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants