Skip to content

Use TimeValue for timeouts in safeAwait etc. #126509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2025
Merged

Use TimeValue for timeouts in safeAwait etc. #126509

merged 3 commits into from
Apr 11, 2025

Conversation

DaveCTurner
Copy link
Contributor

There's no need to force callers to deconstruct the TimeValue in their
possession into a long and a TimeUnit, we can do it ourselves.

@DaveCTurner
Use TimeValue for timeouts in safeAwait etc.
262f761 
There's no need to force callers to deconstruct the `TimeValue` in their
possession into a `long` and a `TimeUnit`, we can do it ourselves.
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. labels Apr 9, 2025
@DaveCTurner DaveCTurner requested a review from ywangd April 9, 2025 07:27
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Apr 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

ywangd
ywangd approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 11, 2025
@elasticsearchmachine elasticsearchmachine merged commit 800cf72 into elastic:main Apr 11, 2025
17 checks passed
@DaveCTurner DaveCTurner deleted the 2025/04/09/safeAwait-TimeValue-timeout branch April 11, 2025 16:46
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 11, 2025
@DaveCTurner
Use TimeValue for timeouts in safeAwait etc. (elastic#126509)
7b59385 
There's no need to force callers to deconstruct the `TimeValue` in their
possession into a `long` and a `TimeUnit`, we can do it ourselves.
@DaveCTurner DaveCTurner mentioned this pull request Apr 11, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.x

elasticsearchmachine pushed a commit that referenced this pull request Apr 11, 2025
@DaveCTurner
Use TimeValue for timeouts in safeAwait etc. (#126509) (#126711)
abfbe1d 
There's no need to force callers to deconstruct the `TimeValue` in their
possession into a `long` and a `TimeUnit`, we can do it ourselves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywangd ywangd ywangd approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaveCTurner @elasticsearchmachine @ywangd