ES|QL: generative tests - fix identifiers generation and source field mapping #126514
Conversation
luigidellaquila
added
>test
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
| @@ -526,4 +526,8 @@ private static String constantExpression() { | |||
|
|
|||
| } | |||
|
|
|||
| private static String randomIdentifier() { | |||
| return randomAlphaOfLength(randomIntBetween(8, 12)); | |||
There was a problem hiding this comment.
Let's add a comment that explains that having at least 8 chars prevents us from accidentally using the not keyword; maybe future us will want the 3 char identifiers back, and will have to exclude not specifically.
There was a problem hiding this comment.
You might borrow/import one from EsTestCase:
elasticsearch/test/framework/src/main/java/org/elasticsearch/test/ESTestCase.java
Lines 1278 to 1280 in 1943844
There was a problem hiding this comment.
I'd say let's keep it as it is, the comment is the only real added value, but maybe it will save us from future headaches
| @@ -315,7 +315,7 @@ private static boolean isLookupDataset(TestDataset dataset) throws IOException { | |||
| return (mode != null && mode.equalsIgnoreCase("lookup")); | |||
| } | |||
|
|
|||
| private static boolean isSourceMappingDataset(TestDataset dataset) throws IOException { | |||
There was a problem hiding this comment.
Yes, started using it in the query generator, but then I simplified the code.
Reverting now
|
Thanks @alex-spies! |
…entifiers' into esql/generative_test_identifiers
Making generative tests more stable by generating longer identifiers (avoiding collisions with reserved keywords).
Also fixing the way we manage environments where source field mapping is not supported