Skip to content

[DO NOT MERGE] ESQL: PoC for name qualifiers #126531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
45dbae9
First attempt at qualifier grammar + some tests
alex-spies Feb 18, 2025
0495b99
Merge remote-tracking branch 'upstream/main' into qualifier-poc
alex-spies Feb 21, 2025
9d5645c
WIP: Update all NamedExpression c'tors
alex-spies Feb 21, 2025
9ad8093
More WIP
alex-spies Mar 10, 2025
7de25ac
Make it compile
alex-spies Mar 10, 2025
6e38051
Make the tests compile, too
alex-spies Mar 10, 2025
8d75844
Fix Alias c'tor
alex-spies Mar 10, 2025
31401c8
Fix mistakes when using UnresolvedAttribute
alex-spies Mar 10, 2025
721e62d
Fix another UnresolvedAttribute usage
alex-spies Mar 10, 2025
abf1008
Fix grammar
alex-spies Mar 12, 2025
7713ecf
WIP
alex-spies Mar 12, 2025
7afdae4
Use qualifiers when resolving
alex-spies Mar 14, 2025
af60385
Add qualifier to UnresolvedRelation
alex-spies Mar 14, 2025
cce600a
Propagate qualifier into FROM resolution
alex-spies Mar 14, 2025
31f0ca3
Make first csv test work with FROM
alex-spies Mar 14, 2025
e999a06
Update tests
alex-spies Mar 17, 2025
fe0a29a
Make EVAL without shadowing work
alex-spies Mar 17, 2025
4fa5c4c
Make RENAME test run
alex-spies Mar 17, 2025
6bf6bb7
Update LOOKUP JOIN test
alex-spies Mar 17, 2025
3d0bd82
Fix LOOKUP JOIN grammar with qualifiers
alex-spies Mar 18, 2025
6307cc3
Improve JOIN grammar, add more LOOKUP JOIN tests
alex-spies Mar 18, 2025
da70688
Make lookup join resolution qualifier-aware
alex-spies Mar 18, 2025
ae66bc8
Make most LOOKUP JOIN tests pass
alex-spies Mar 18, 2025
21139ae
Merge remote-tracking branch 'upstream/main' into qualifier-poc
alex-spies Mar 18, 2025
3b475bb
Merge remote-tracking branch 'upstream/main' into qualifier-poc
alex-spies Apr 8, 2025
6824302
Enable LOOKUP JOIN ... ON left attr == right other
alex-spies Apr 9, 2025
ff4ea32
Merge remote-tracking branch 'upstream/main' into qualifier-poc
alex-spies Apr 9, 2025
cb221a6
Fix tests
alex-spies Apr 9, 2025
8d056f3
Disable failing tests
alex-spies Apr 9, 2025
3d4c40f
Fix test case
alex-spies Apr 9, 2025
6403e8c
Disable the new yml tests for now
alex-spies Apr 9, 2025
ffcdd82
Revert "Disable the new yml tests for now"
alex-spies Apr 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Alias c'tor
  • Loading branch information
alex-spies committed Mar 10, 2025
commit 8d75844a1e77e0576a9b0229a38162ab1acc7bbe
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public Alias(Source source, @Nullable String qualifier, String name, Expression
}

public Alias(Source source, @Nullable String qualifier, String name, Expression child, @Nullable NameId id) {
this(source, name, qualifier, child, id, false);
this(source, qualifier, name, child, id, false);
}

public Alias(Source source, @Nullable String qualifier, String name, Expression child, @Nullable NameId id, boolean synthetic) {
Expand Down