Fix ELAND endpoints not updating dimensions #126537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-rubinstein
added
>bug
:ml
|
Hi @dan-rubinstein, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
wwang500
added
the
cloud-deploy
jonathan-buttner
approved these changes
Apr 9, 2025
prwhelan
approved these changes
Apr 9, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
dan-rubinstein
added a commit
to dan-rubinstein/elasticsearch
that referenced
this pull request
Apr 9, 2025
* Fix ELAND endpoints not updating dimensions * Update docs/changelog/126537.yaml
dan-rubinstein
added a commit
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a previous change endpoint creation validation was added for all task types for ElasticsearchInternalService. As part of this change, a bug was introduced that stopped ELAND text embedding models from updating their dimensions after model validation causing endpoints to fail creation. This change adds back the dimension updating logic.
Testing