Reduce assertBusy usage in testMultipleNodes
#126582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
ywangd
approved these changes
Apr 10, 2025
| @@ -124,10 +124,6 @@ protected void deleteMonitoringIndices() { | |||
| assertAcked(client().admin().indices().prepareDelete(ALL_MONITORING_INDICES)); | |||
| } | |||
|
|
|||
| protected void ensureMonitoringIndicesYellow() { | |||
| ensureYellowAndNoInitializingShards(".monitoring-es-*"); | |||
There was a problem hiding this comment.
ALL_MONITORING_INDICES is "monitoring-* and this is .monitoring-es-*. I doubt the difference would actual matter. But probably still better to be safe and use .monitoring-es-* in awaitClusterState?
There was a problem hiding this comment.
Ah well spotted :) Yeah it doesn't matter I think, we're only monitoring ES itself in this test, but I fixed that up.
DaveCTurner
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #126501